Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 189
    • Merge requests 189
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !38378

Closed
Created Nov 18, 2020 by Oliver Majersky@omajerskDeveloper
  • Report abuse
Report abuse

Fix typo in ElectronPhotonFourMomentumCorrection CMakeLists.txt

  • Overview 6
  • Commits 1
  • Pipelines 1
  • Changes 1

Title says it all, there is a typo INCUDE instead of INCLUDE in the CMakeLists of the ElectronPhotonFourMomentumCorrection package. When we try to build AnalysisTop packages, we get CMake configuration errors, because our pacakges (among other things) depend on this package, which has a broken configuration.

What I find worrying is that, this typo was not picked up by CI jobs. Not an expert on CI, to my limited understanding it does some caching of built packages to shorted the build time. However this suggests that changes of CMakeLists.txt do not properly retrigger the build process.

Thanks to @bmondal for spotting the typo.

Edited Nov 18, 2020 by Oliver Majersky
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-ElectronPhotonID-CMake