From fbf75aeb89925784144b9b0b8564fddbd955bed4 Mon Sep 17 00:00:00 2001
From: Matthew Thomas Anthony <matthew.thomas.anthony@cern.ch>
Date: Thu, 11 Mar 2021 16:31:12 +0000
Subject: [PATCH 1/2] debug a small (1 in 10^7) error relating to dR matching
in muons/CFE - most likely bad author/track
---
.../PFOHistUtils/FlowElement_LinkerPlots.h | 2 ++
.../PFOHistUtils/src/FlowElement_LinkerPlots.cxx | 15 +++++++++++++--
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/Reconstruction/PFlow/PFlowValidation/PFOHistUtils/PFOHistUtils/FlowElement_LinkerPlots.h b/Reconstruction/PFlow/PFlowValidation/PFOHistUtils/PFOHistUtils/FlowElement_LinkerPlots.h
index d2f3ba1222c6..06acf6018fe9 100644
--- a/Reconstruction/PFlow/PFlowValidation/PFOHistUtils/PFOHistUtils/FlowElement_LinkerPlots.h
+++ b/Reconstruction/PFlow/PFlowValidation/PFOHistUtils/PFOHistUtils/FlowElement_LinkerPlots.h
@@ -37,6 +37,8 @@ namespace PFO{
TH1* m_CFE_muon_dR;
TH1* m_CFE_muon_NMatchedMuon;
TH1* m_CFE_muon_muonNMatchedFE;
+ TH1* m_CFE_muon_largeDR_debug_author;
+ TH1* m_CFE_muon_largeDR_debug_type;
TH1* m_NFE_muon_dR;
TH1* m_NFE_muon_NMatchedMuon;
diff --git a/Reconstruction/PFlow/PFlowValidation/PFOHistUtils/src/FlowElement_LinkerPlots.cxx b/Reconstruction/PFlow/PFlowValidation/PFOHistUtils/src/FlowElement_LinkerPlots.cxx
index 04ce4d5da6e6..0939215a13d4 100644
--- a/Reconstruction/PFlow/PFlowValidation/PFOHistUtils/src/FlowElement_LinkerPlots.cxx
+++ b/Reconstruction/PFlow/PFlowValidation/PFOHistUtils/src/FlowElement_LinkerPlots.cxx
@@ -29,6 +29,8 @@ namespace PFO {
m_CFE_muon_dR=nullptr;
m_CFE_muon_NMatchedMuon=nullptr;
m_CFE_muon_muonNMatchedFE=nullptr;
+ m_CFE_muon_largeDR_debug_author=nullptr;
+ m_CFE_muon_largeDR_debug_type=nullptr;
m_NFE_muon_dR=nullptr;
m_NFE_muon_NMatchedMuon=nullptr;
@@ -87,6 +89,8 @@ namespace PFO {
m_CFE_muon_dR=Book1D("_CFE_muon_dR",m_sFEContainerName+"_CFE_muon_dR",40,0,5);
m_CFE_muon_NMatchedMuon=Book1D("_CFE_muon_NMatchedMuon",m_sFEContainerName+"_CFE_muon_NMatchedMuon",20,0,20);
m_CFE_muon_muonNMatchedFE=Book1D("_CFE_muon_muonNMatchedFE",m_sFEContainerName+"_CFE_muon_muonNMatchedFE",20,0,20);
+ m_CFE_muon_largeDR_debug_author=Book1D("_CFE_muon_largeDR_debug_author",m_sFEContainerName+"_CFE_muon_largeDR_debug_author",20,0,20);
+ m_CFE_muon_largeDR_debug_type=Book1D("_CFE_muon_largeDR_debug_type",m_sFEContainerName+"_CFE_muon_largeDR_debug_author",20,0,20);
}
else{
m_NFE_muon_dR=Book1D("_NFE_muon_dR",m_sFEContainerName+"_NFE_muon_dR",40,0,5);
@@ -134,8 +138,15 @@ namespace PFO {
continue;
if(m_doNeutralFE)
m_NFE_muon_dR->Fill(deltaR);
- else
- m_CFE_muon_dR->Fill(deltaR);
+ else{
+ m_CFE_muon_dR->Fill(deltaR);
+ if(deltaR>1){// should never happen, but catch for extreme cases
+ int auth=muon->author;
+ int type=muon->type;
+ m_CFE_muon_largeDR_debug_author->Fill(auth);
+ m_CFE_muon_largeDR_debug_type->Fill(type);
+ }
+ }// end of CFE fill block for muon_dR code
}
}// end of muon acc block
--
GitLab
From a75d614f40ed1bad868d90384926d2a33bd3bac7 Mon Sep 17 00:00:00 2001
From: Matthew Thomas Anthony <matthew.thomas.anthony@cern.ch>
Date: Thu, 11 Mar 2021 17:20:53 +0000
Subject: [PATCH 2/2] add a small debug for muon CFE link
---
.../PFOHistUtils/src/FlowElement_LinkerPlots.cxx | 6 +++---
.../PFOHistUtils/src/PFO_FE_Comparison_PlotMaker.cxx | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/Reconstruction/PFlow/PFlowValidation/PFOHistUtils/src/FlowElement_LinkerPlots.cxx b/Reconstruction/PFlow/PFlowValidation/PFOHistUtils/src/FlowElement_LinkerPlots.cxx
index 0939215a13d4..ced0f92c7f55 100644
--- a/Reconstruction/PFlow/PFlowValidation/PFOHistUtils/src/FlowElement_LinkerPlots.cxx
+++ b/Reconstruction/PFlow/PFlowValidation/PFOHistUtils/src/FlowElement_LinkerPlots.cxx
@@ -90,7 +90,7 @@ namespace PFO {
m_CFE_muon_NMatchedMuon=Book1D("_CFE_muon_NMatchedMuon",m_sFEContainerName+"_CFE_muon_NMatchedMuon",20,0,20);
m_CFE_muon_muonNMatchedFE=Book1D("_CFE_muon_muonNMatchedFE",m_sFEContainerName+"_CFE_muon_muonNMatchedFE",20,0,20);
m_CFE_muon_largeDR_debug_author=Book1D("_CFE_muon_largeDR_debug_author",m_sFEContainerName+"_CFE_muon_largeDR_debug_author",20,0,20);
- m_CFE_muon_largeDR_debug_type=Book1D("_CFE_muon_largeDR_debug_type",m_sFEContainerName+"_CFE_muon_largeDR_debug_author",20,0,20);
+ m_CFE_muon_largeDR_debug_type=Book1D("_CFE_muon_largeDR_debug_type",m_sFEContainerName+"_CFE_muon_largeDR_debug_type",20,0,20);
}
else{
m_NFE_muon_dR=Book1D("_NFE_muon_dR",m_sFEContainerName+"_NFE_muon_dR",40,0,5);
@@ -141,8 +141,8 @@ namespace PFO {
else{
m_CFE_muon_dR->Fill(deltaR);
if(deltaR>1){// should never happen, but catch for extreme cases
- int auth=muon->author;
- int type=muon->type;
+ int auth=muon->author();
+ int type=muon->muonType();
m_CFE_muon_largeDR_debug_author->Fill(auth);
m_CFE_muon_largeDR_debug_type->Fill(type);
}
diff --git a/Reconstruction/PFlow/PFlowValidation/PFOHistUtils/src/PFO_FE_Comparison_PlotMaker.cxx b/Reconstruction/PFlow/PFlowValidation/PFOHistUtils/src/PFO_FE_Comparison_PlotMaker.cxx
index ef891d5b86fe..eba5b090e1f5 100644
--- a/Reconstruction/PFlow/PFlowValidation/PFOHistUtils/src/PFO_FE_Comparison_PlotMaker.cxx
+++ b/Reconstruction/PFlow/PFlowValidation/PFOHistUtils/src/PFO_FE_Comparison_PlotMaker.cxx
@@ -252,7 +252,7 @@ namespace PFO {
float Ratio_PFO_FE_moment_AVG_LAR_Q = -1.0;
if(FE_moment_AVG_LAR_Q){
Ratio_PFO_FE_moment_AVG_LAR_Q=pfo_moment_AVG_LAR_Q/FE_moment_AVG_LAR_Q;
- ATH_MSG_INFO("AVG_LAR_Q: (PFO) "<<pfo_moment_AVG_LAR_Q<<" (FE) "<<FE_moment_AVG_LAR_Q);
+ ATH_MSG_DEBUG("AVG_LAR_Q: (PFO) "<<pfo_moment_AVG_LAR_Q<<" (FE) "<<FE_moment_AVG_LAR_Q);
}
float Ratio_PFO_FE_moment_AVG_TILE_Q = -1.0;
if(FE_moment_AVG_TILE_Q){
--
GitLab