From 0a27b8e5fcd84a765456ff1b435a7e14cd1beace Mon Sep 17 00:00:00 2001 From: sutt <sutt@cern.ch> Date: Wed, 31 Mar 2021 20:33:11 +0200 Subject: [PATCH 1/3] Plot timings on a log x scale by default For some of the cost moniotring histograms, the imes are sort with long tails and it is difficult to see what is going on The request by default, plots the time on a logx scale --- .../TrigInDetValidation/python/TrigInDetArtSteps.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Trigger/TrigValidation/TrigInDetValidation/python/TrigInDetArtSteps.py b/Trigger/TrigValidation/TrigInDetValidation/python/TrigInDetArtSteps.py index e0fb1c1c247d..f318fc6ce658 100644 --- a/Trigger/TrigValidation/TrigInDetValidation/python/TrigInDetArtSteps.py +++ b/Trigger/TrigValidation/TrigInDetValidation/python/TrigInDetArtSteps.py @@ -289,8 +289,8 @@ class TrigInDetCpuCostStep(RefComparisonStep): def configure(self, test): RefComparisonStep.configure(self, test) if self.reference is None : - self.args = self.input_file + " -o " + self.output_dir + " " + self.extra + "--noref" + self.args = self.input_file + " -o " + self.output_dir + " " + self.extra + "--noref --logx " else: - self.args = self.input_file + " " + self.reference + " -o " + self.output_dir + " " + self.extra + self.args = self.input_file + " " + self.reference + " -o " + self.output_dir + " " + self.extra + " --logx " Step.configure(self, test) -- GitLab From 13579e03b6ad97a18dac794b8adf5c3d8631ab28 Mon Sep 17 00:00:00 2001 From: sutt <sutt@cern.ch> Date: Thu, 1 Apr 2021 09:52:22 +0200 Subject: [PATCH 2/3] Extend d0 distribution ranges also --- .../TrigInDetAnalysisUser/share/TIDAhisto-panel.dat | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Trigger/TrigAnalysis/TrigInDetAnalysisUser/share/TIDAhisto-panel.dat b/Trigger/TrigAnalysis/TrigInDetAnalysisUser/share/TIDAhisto-panel.dat index 83a5000f8fc7..e3ab8259c4b6 100644 --- a/Trigger/TrigAnalysis/TrigInDetAnalysisUser/share/TIDAhisto-panel.dat +++ b/Trigger/TrigAnalysis/TrigInDetAnalysisUser/share/TIDAhisto-panel.dat @@ -59,8 +59,8 @@ dist_panel = { "eta", "eta", "xaxis:lin:auto:1:100", "Reference #eta", "yaxis:lin:auton", "Normalised entries", "eta_rec", "eta rec", "xaxis:lin:auto:1:100", "Trigger #eta", "yaxis:lin:auton", "Normalised entries", - "a0", "a0", "xaxis:lin:-3:3", "Reference a_{0} [mm]", "yaxis:log:auton", "Normalised entries", - "a0_rec", "a0 rec", "xaxis:lin:-3:3", "Trigger a_{0} [mm]", "yaxis:log:auton", "Normalised entries", + "a0", "a0", "xaxis:lin:autosym:-3:3", "Reference a_{0} [mm]", "yaxis:log:auton", "Normalised entries", + "a0_rec", "a0 rec", "xaxis:lin:autosym:-3:3", "Trigger a_{0} [mm]", "yaxis:log:auton", "Normalised entries", "z0", "z0", "xaxis:lin:-200:200", "Reference z_{0} [mm]", "yaxis:log:auton", "Normalised entries", "z0_rec", "z0_rec", "xaxis:lin:-200:200", "Trigger z_{0} [mm]", "yaxis:log:auton", "Normalised entries" -- GitLab From f3a22fd4527a5d3533921c5c10f99c28b7a236f2 Mon Sep 17 00:00:00 2001 From: sutt <sutt@cern.ch> Date: Sun, 4 Apr 2021 13:53:13 +0200 Subject: [PATCH 3/3] While waiting for this to be approved and merged might as well make another change --- .../TrigAnalysis/TrigInDetAnalysisUser/Analysis/src/computils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Trigger/TrigAnalysis/TrigInDetAnalysisUser/Analysis/src/computils.h b/Trigger/TrigAnalysis/TrigInDetAnalysisUser/Analysis/src/computils.h index c56d79a53789..20ff261349a5 100644 --- a/Trigger/TrigAnalysis/TrigInDetAnalysisUser/Analysis/src/computils.h +++ b/Trigger/TrigAnalysis/TrigInDetAnalysisUser/Analysis/src/computils.h @@ -955,7 +955,7 @@ public: for ( unsigned i=0 ; i<size() ; i++ ) at(i).trim_errors( m_trim_errors ); for ( unsigned i=0 ; i<size() ; i++, first=false ) at(i).Draw( i, leg, means, first ); - if ( watermark ) DrawLabel(0.1, 0.02, "built on "+stime()+release, kBlack, 0.03 ); + if ( watermark ) DrawLabel(0.1, 0.02, "built "+stime()+release, kBlack, 0.03 ); gPad->SetLogy(m_logy); gPad->SetLogx(m_logx); -- GitLab