Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 128
    • Merge requests 128
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !42450

introduce StandaloneToolHandle and update existing uses of AnaToolHandle in standalone applications

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Nils Erik Krumnack requested to merge krumnack/athena:sa_tool_handle into master Apr 09, 2021
  • Overview 18
  • Commits 2
  • Pipelines 2
  • Changes 45

After @christos mentioned in yesterday's core software meeting that a lot of users of AnaToolHandle are indeed tests and standalone applications I now added a new class StandaloneToolHandle that should be able to serve as a simple replacement of AnaToolHandle in such circumstances.

This has two benefits:

  • the new class avoids a lot of the complexities and potential problems in AnaToolHandle that should not be relevant for stand-alone applications
  • with AnaToolHandle no longer responsible for this use case I can hopefully drop support for public tools from AnaToolHandle, or at the very least no longer make it the default behavior

The plan is also to sweep this into 21.2, but I'll do that manually, as I expect that with this many packages touched there will be some conflicts.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: sa_tool_handle