Skip to content

removed optional argument from -AthConfigFlags- constructor

Kacper Wojciech Topolnicki requested to merge ktopolni/athena:master-change-constructor into master

No invocations of the -AthConfigFlags- constructor that use the optional -inputflags- argument were found outside of -Control/AthenaConfiguration-. Using this argument without -deepcopy- might be problematic. Two methods from the -AthConfigFlags- class that used this argument were modified appropriately.

Tests performed:

Test project /afs/cern.ch/user/k/ktopolni/private/git_tutorial_15_03_2020/build Start 1: AthenaConfiguration_AthConfigFlagsTest_ctest Start 2: AthenaConfiguration_MainServicesConfig_ctest Start 3: AthenaConfiguration_ComponentAccumulatorTest_ctest 1/11 Test #1: AthenaConfiguration_AthConfigFlagsTest_ctest ............. Passed 1.01 sec Start 4: AthenaConfiguration_AllConfigFlagsTest_EVNT_test_ctest 2/11 Test #2: AthenaConfiguration_MainServicesConfig_ctest ............. Passed 1.83 sec Start 5: AthenaConfiguration_DetectorConfigFlags_test_ctest 3/11 Test #3: AthenaConfiguration_ComponentAccumulatorTest_ctest ....... Passed 3.07 sec Start 6: AthenaConfiguration_AllConfigFlagsTest_HITS_test_ctest 4/11 Test #5: AthenaConfiguration_DetectorConfigFlags_test_ctest ....... Passed 1.80 sec Start 7: AthenaConfiguration_AllConfigFlagsTest_RDO_test_ctest 5/11 Test #4: AthenaConfiguration_AllConfigFlagsTest_EVNT_test_ctest ... Passed 11.68 sec Start 8: AthenaConfiguration_AllConfigFlagsTest_ctest 6/11 Test #6: AthenaConfiguration_AllConfigFlagsTest_HITS_test_ctest ... Passed 9.79 sec Start 9: AthenaConfiguration_ComponentAccumulatorTestReco_ctest 7/11 Test #9: AthenaConfiguration_ComponentAccumulatorTestReco_ctest ... Passed 1.34 sec Start 10: TrigInDetConfig_trigInDetFastTrackingCfg_ctest 8/11 Test #10: TrigInDetConfig_trigInDetFastTrackingCfg_ctest ........... Passed 9.01 sec Start 11: TrigInDetConfig_TrigTrackingCutFlags_ctest 9/11 Test #11: TrigInDetConfig_TrigTrackingCutFlags_ctest ............... Passed 1.18 sec 10/11 Test #7: AthenaConfiguration_AllConfigFlagsTest_RDO_test_ctest .... Passed 25.95 sec

11/11 Test #8: AthenaConfiguration_AllConfigFlagsTest_ctest ............. Passed 71.81 sec

100% tests passed, 0 tests failed out of 11

@tbold @rbielski ATR-23200 https://its.cern.ch/jira/browse/ATR-23200

Merge request reports