Skip to content

Synchronised ID Trigger flags between the new JO and mainline config

Tomasz Bold requested to merge tbold/athena:sync-id-trig-flags into master

In this MR a temporary (no expiration date though) measure is coded to synchronize ID tracking flags setting between newJO and existing mainline developement. All works as expected however there is one annoyance. The threshold minPT used in the offline set of flags vs pTmin used in the trigger. Here is a question to @sutt If both settings should be synchronized then we better use the same name (minPT hopefully). If they can be sometimes different can we call one maybe FTFminPT?

I have put a hack in place. A better one would be to rename property: _pTmin to be minPT and change the property pTmin to use it. Maybe too confusing.

One other thing that I needed to touch are flags that have value None. NewJO flags do not allow that so I changed all the keys to: "" (and touched places that required modifications due to that). It is quite clear IMHO, however, maybe not to everyone. @sutt - please let me know.

Merge request reports