Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 157
    • Merge requests 157
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !44419

Fix FPE due to log(X) where X <= 0 in jet mass calibration

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Steven Schramm requested to merge sschramm/athena:21.2-fix-JMS-FPE into 21.2 Jun 15, 2021
  • Overview 7
  • Commits 1
  • Pipelines 2
  • Changes 1

This FPE was first seen in r22 (https://its.cern.ch/jira/browse/ATR-23551), but is present in both r21 and r22. This commit is the r21 fix, which can then be cherry-picked into r22. Note that the choice was made to keep the same behaviour as the current tool, which looked for NaNs instead of preventing their creation in the first place. That is, negative logarithms result in a calibration factor of 1 (no calibration) or a calibration weight of 0 (for combined mass calibrations).

Edited Jun 16, 2021 by Steven Schramm
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: 21.2-fix-JMS-FPE