Skip to content

SuperClusterBuilder. Rename the Base class to egammaSuperClusterBase. Then we...

Christos Anastopoulos requested to merge ATLAS-EGamma/athena:egammaSuperClusterBuilder_refactor_trackless into master

SuperClusterBuilder. Rename the Base class to egammaSuperClusterBuilderBase from egammaSuperClusterBuilder.

Then we have 3 classes , implementing 3 policies depending on what we want. An idea of what is possible is here [https://atlas.web.cern.ch/Atlas/GROUPS/PHYSICS/PAPERS/EGAM-2018-01/fig_03.png]

  • Tracking and Electrons electronSupeClusterBuilder.
  • No Tracking/Tracking and Photons photonSuperClusterBuilder.
  • No Tracking but generic objects mainly useful for creating electons when no tracking is there (photons we can do anyhow) egammaSuperClusterBuilder.

Mentioning @sutt and @tamartin . This at the end is up to you but this is kind of the change @sutt wanted to have or at least a first implementation of it.

For the benefit of the reviewer the only new code is in egammaSuperClusterBuilder.

egammaSuperClusterBuilderBase is what used to be there under egammaSuperClusterBuilder. The diff is a bit confused or moving out (git mv) code to "Base" and the creating a new egammaSuperClusterBuilder

Edited by Christos Anastopoulos

Merge request reports