Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 143
    • Merge requests 143
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !45972

[L1TopoEvent] Make slicing and narrowing casts explicit

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Rafal Bielski requested to merge rbielski/athena:l1topoevent-narrowing into master Aug 20, 2021
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 4

Turn implicit slicing and narrowing into explicit. Multiple cases of each of the following clang-tidy warnings are fixed:

  • narrowing conversion from 'unsigned int' to signed type 'int' is implementation-defined [bugprone-narrowing-conversions]
  • slicing object from type ... to 'BaseTOB' discards ... bytes of state [cppcoreguidelines-slicing]
  • slicing object from type ... to 'BaseTOB' discards override 'print' [cppcoreguidelines-slicing]
  • slicing object from type ... to 'BaseTOB' discards override 'tobType' [cppcoreguidelines-slicing]
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: l1topoevent-narrowing