Skip to content

ByteStreamEmonSvc: Read L1 item name to ID mapping from L1Menu instead of IS

Rafal Bielski requested to merge rbielski/athena:emon-bs-read-menu into master

Remove ancient (Run-1) code for mapping L1 item names to IDs from ByteStreamEmonSvc and replace with Run-3 solution. The old code (which was decorated with a comment calling it "pure madness" 😆) was actually obsolete already in Run 2 but due to a series of lucky coincidences somehow still worked throughout the run. Now it stopped working and is replaced with a contemporary solution using ReadHandle<TrigConf::L1Menu>. The name to ID mapping will be now read from TriggerDB instead of IS.

Tested already to work at P1. I saw:

2021-10-20 17:57:38,136 ByteStreamInputSvc  DEBUG Reading L1Menu to map LVL1Names to CTP IDs
2021-10-20 17:57:38,136 ByteStreamInputSvc  DEBUG Item L1_RD0_EMPTY mapped to CTP ID 118

Fixes ATR-24370

Merge request reports