Skip to content

Manual sweep of !39716 from 21.0 to master: Make McEventCollectionCnv_p5_test and McEventCollectionCnv_p4_test more robust

John Derek Chapman requested to merge jchapman/athena:Sweep39716to_master into master

Merge rewuest makes McEventCollectionCnv_p5_test and McEventCollectionCnv_p4_test more robust by:

  • checking all properties of the GenEvent.
  • GenVertex positions not at (0,0,0) to properly test TP conversion of those variables.
  • some double-precision properties are only stored with single-precision in the persistent version, so must be cast to float before being compared.

The current HepMC2-based versions of McEventCollectionCnv_p5 and McEventCollectionCnv_p4 used in the master nightlies flip the order of the GenParticles associated with each GenVertex after T1->P1->T2 conversion. Running though this twice is sufficient to regain agreement (i.e. T1->P1->T2->P2->T3. T1 == T3 != T2).

The HepMC3-based versions of McEventCollectionCnv_p5 and McEventCollectionCnv_p4 do not have this issue (i.e. T1 == T2).

See merge request !39716 (merged)

(Should be merged after !47934 (merged).)

Edited by John Derek Chapman

Merge request reports