Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 176
    • Merge requests 176
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !49569

TrigDecisionTool: thread-safety fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Frank Winklmeier requested to merge fwinkl/athena:tdt_thrchk1 into master Jan 11, 2022
  • Overview 6
  • Commits 4
  • Pipelines 2
  • Changes 20

A first set of changes to make TrigDecisionTool pass the thread-checker:

  • Make the StoreGateSvc::keys method const (cc @ssnyder)
  • Use asg::EventStoreType instead of custom typedefs for event store pointers and also make them const.
  • Remove the DataHandle inheritance of the various DecisionObjectHandle classes and remove the internal caching of the decision object as the ReadHandle(Key) already does its own caching.
  • Add thread-checker annotations for the Logger class.

cc @tamartin @jburr

Edited Jan 12, 2022 by Frank Winklmeier
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: tdt_thrchk1