Skip to content

GitLab

IExtrapolator rm legacy / fallback Event Context unaware methods

Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:IExtrapolator_rm_NoCtx_fallback into master

IExtrapolator rm legacy / fallback Event Context unaware methods that were doing implicit/hidden retrievals/lookups.

i.e remove these kind of methods:

inline const Trk::TrackParameters*
Trk::IExtrapolator::extrapolate(const xAOD::TrackParticle& particleBase,
                                ....) const
{
    return extrapolate( Gaudi::Hive::currentContext(),
                        particleBase...);
}

using the above meant as example that in a loop 1... N we do the lookup N times..

Make the retrievals explicit (visible so we can futher optimise here if we ever need/want) on the client code. Also tried to fix the obvious "too many" lookups. We can further reduce them but we need then to also change method interfaces on the client side.

follow up to

ping @sroe and @tadej I expect quite a few clients to use the methods the implicitly retrieve the ctx . Let the CI notify us

Edited by Christos Anastopoulos