Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 168
    • Merge requests 168
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !49667

Merged
Created Jan 14, 2022 by Daniele Zanzi@dzanziDeveloper

Remove “1” and “N” designations in hypo name (ATR-22834)

  • Overview 7
  • Commits 2
  • Pipelines 1
  • Changes 2

This should address ATR-22834, but since this is code I am not familiar with I would ask @hrussell @khoo @tamartin to check. CI tests are successful and now I am checking that the counts are not changed. However, if this breaks some combined chains we may not see count changes in the local tests...

With this fix, the steps

        "Step1_1FastCalo_electron": [
            "RoRSeqFilter/FStep1_1FastCalo_electron",
            "EventViewCreatorAlgorithm/IMfastCalo",
            "AthViews::ViewDataVerifier/fastCaloVDV",
            "T2CaloEgammaReFastAlgo/FastCaloL2EgammaAlg",
            "TrigEgammaFastCaloHypoAlg/ElectronEgammaFastCaloHypo",
            "ComboHypo/ComboHypo_Step1_1FastCalo_electron"
        ],
        "Step1_NFastCalo_electron": [
            "RoRSeqFilter/FStep1_NFastCalo_electron",
            "EventViewCreatorAlgorithm/IMfastCalo",
            "AthViews::ViewDataVerifier/fastCaloVDV",
            "T2CaloEgammaReFastAlgo/FastCaloL2EgammaAlg",
            "TrigEgammaFastCaloHypoAlg/ElectronEgammaFastCaloHypo",
            "ComboHypo/ComboHypo_Step1_NFastCalo_electron"
        ],

are now the same

        "Step1_FastCalo_electron": [
            "RoRSeqFilter/FStep1_FastCalo_electron",
            "EventViewCreatorAlgorithm/IMfastCalo",
            "AthViews::ViewDataVerifier/fastCaloVDV",
            "T2CaloEgammaReFastAlgo/FastCaloL2EgammaAlg",
            "TrigEgammaFastCaloHypoAlg/ElectronEgammaFastCaloHypo",
            "ComboHypo/ComboHypo_Step1_FastCalo_electron"
        ],
Edited Jan 14, 2022 by Daniele Zanzi
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: ATR-22834_dzanzi