Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 236
    • Merge requests 236
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !49779

Merged
Created Jan 19, 2022 by Frank Winklmeier@fwinklMaintainer

TrigDecisionTool: remove DecisionObjectHandle classes

  • Overview 10
  • Commits 1
  • Pipelines 1
  • Changes 17

This is a more radical attempt at getting rid of the internal caching in the unpacker classes which was attempted in !49569 (merged) and had to be reverted due to performance issues in !49733 (merged). I think most of the code is historic and given we have universal support for ReadHandle in both the athena and the analysis release, there is probably no good reason to have a separate DecisionObjectHandle anymore.

So this MR removes the DecisionObjectHandle classes and instead uses a ReadHandle directly in the unpacker classes. Also make the unpackers stateless and move the logic if the decision (navigation) was already unpacked into CacheGlobalMemory.

cc @tamartin @jburr

Edited Jan 21, 2022 by Frank Winklmeier
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: tdt_handle