Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 188
    • Merge requests 188
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !49807

Merged
Created Jan 20, 2022 by Frank Winklmeier@fwinklMaintainer

TrigDecisionTool: avoid mutables in FeatureContainer

  • Overview 8
  • Commits 1
  • Pipelines 1
  • Changes 4

Instead of removing duplicates in the call of getCombinations (and cache the result), do the duplicate removal when adding elements in the container. Switch from using a set to an unordered_set as that seems to be slightly faster (required adding a hash function for Trig::Combination).

Also apply some other minor code cleanups and inline comparison operators.

Overall this new code does not seem to perform any worse than the old solution. At least not in the workflows I tested. Not sure if there were any measurement done at the time when the rather complicated getCombinations was first implemented.

cc @tbold @tamartin @jburr (some careful review would be appreciated)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: tdt_fc