Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 144
    • Merge requests 144
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Code review
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • atlasatlas
  • athenaathena
  • Merge requests
  • !49948

moved checkSequenceConsistency

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Kacper Wojciech Topolnicki requested to merge ktopolni/athena:verifySequenceConsistency_from_nightly into master Jan 25, 2022
  • Overview 26
  • Commits 12
  • Pipelines 4
  • Changes 3

Moved -checkSequenceConsistency- to -run- and -store- to improve configuration speed.

Results in around 10s speedup when running:

python runHLT_standalone_newJO.py --filesInput=/cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/TrigP1Test/data18_13TeV.00360026.physics_EnhancedBias.merge.RAW._lb0151._SFO-1._0001.1 Trigger.triggerMenuSetup=\"Dev_pp_run3_v1\" Trigger.doRuntimeNaviVal=True >athena_run.log 2>&1

additional modifications

Some additional modifications were made to resolve problems related to the move, they are listed below:

  • An additional loop over the children of seq was added to checkSequenceConsistency.
  • The function getSequenceChildren does not exhaust all possibilities for its argument comp. The missing comp.Members resulted in errors after the changes. To mitigate this an empty list [] is returned if Members is not available.
  • The test ForbidRecursiveSequences was modified.

@tbold @rbielski ATR-23200

Edited Jan 28, 2022 by Kacper Wojciech Topolnicki
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: verifySequenceConsistency_from_nightly