From 8374b4ff05057fb38cfd43d1b32f9de2b5fb8720 Mon Sep 17 00:00:00 2001
From: Frank Berghaus <frank.berghaus@cern.ch>
Date: Thu, 27 Jan 2022 08:46:51 -0600
Subject: [PATCH] Demote messages fron GetRunNumber and GetLBNumber

When it is not possible to determine the run or LB number we agreed to
return 'None'. This is to signal clients to settle with working
defaults. As none of those exceptional circumstances are serious
problems error messages of level DEBUG or VERBOSE seem appropriate.
---
 .../RecExConfig/python/AutoConfiguration.py   | 56 ++++++++++---------
 1 file changed, 30 insertions(+), 26 deletions(-)

diff --git a/Reconstruction/RecExample/RecExConfig/python/AutoConfiguration.py b/Reconstruction/RecExample/RecExConfig/python/AutoConfiguration.py
index 76fb254fce5..f2593c59373 100644
--- a/Reconstruction/RecExample/RecExConfig/python/AutoConfiguration.py
+++ b/Reconstruction/RecExample/RecExConfig/python/AutoConfiguration.py
@@ -87,37 +87,37 @@ def GetRunNumber():
         if not rec.RunNumber.isDefault():
             runNb = rec.RunNumber()
     except ImportError:
-        logAutoConfiguration.debug("Could not import from RecFlags, trying "
-                                   "in-file metadata")
+        logAutoConfiguration.verbose("Could not import from RecFlags, trying "
+                                     "in-file metadata")
     try:
         if not runNb:
             from PyUtils.MetaReaderPeeker import metadata
     except ImportError as err:
-        logAutoConfiguration.error(f"Unexpected: {err}")
+        logAutoConfiguration.debug(f"Unexpected: {err}")
         return None
     try:
         if not runNb:
             runNb = metadata['runNumbers'][0]
     except KeyError:
-        logAutoConfiguration.info("no runNumbers from EventStreamInput in "
-                                  "in-file metadata")
+        logAutoConfiguration.verbose("no runNumbers from EventStreamInput in "
+                                     "in-file metadata")
     except IndexError:
-        logAutoConfiguration.debug("Empty list of runNumbers from "
-                                   "EventStreamInfo, trying FileMetaData")
+        logAutoConfiguration.verbose("Empty list of runNumbers from "
+                                     "EventStreamInfo, trying FileMetaData")
     try:
         if not runNb:
             runNb = metadata['FileMetaData']['runNumbers'][0]
     except KeyError:
-        logAutoConfiguration.debug("FileMetaData does not provide runNumbers")
+        logAutoConfiguration.verbose("FileMetaData does not provide runNumbers")
     except IndexError:
-        logAutoConfiguration.debug("Empty list of runNumbers in FileMetaData")
+        logAutoConfiguration.verbose("Empty list of runNumbers in FileMetaData")
     if not runNb:
         try:
             from AthenaCommon.AthenaCommonFlags import athenaCommonFlags
             if not athenaCommonFlags.isOnline():
-                logAutoConfiguration.error("No RunNumber stored in InputFile!")
+                logAutoConfiguration.debug("No RunNumber stored in InputFile!")
         except ImportError as err:
-            logAutoConfiguration.error(f"Unexpected: {err}")
+            logAutoConfiguration.debug(f"Unexpected: {err}")
     logAutoConfiguration.debug(f"RunNumber is: {runNb}")
     return runNb
 
@@ -136,35 +136,39 @@ def GetLBNumber():
         Returns:
             int: lumi block number if successful, None otherwise
     """
-    from PyUtils.MetaReaderPeeker import metadata
+    try:
+        from PyUtils.MetaReaderPeeker import metadata
+    except ImportError as err:
+        logAutoConfiguration.debug(f"Unexpected: {err}")
+        return None
     lbs = None
     try:
         lbs = metadata['lumiBlockNumbers']
     except (KeyError,):
-        logAutoConfiguration.debug("No lumiBlockNumbers from EventStreamInfo")
-    if not lbs:
-        # if EventStreamInfo is empty, try FileMetaData
-        try:
+        logAutoConfiguration.verbose("No lumiBlockNumbers from EventStreamInfo")
+    try:
+        if not lbs:
+            # if EventStreamInfo is empty, try FileMetaData
             lbs = metadata['FileMetaData']['lumiBlocks']
-        except (KeyError,):
-            logAutoConfiguration.debug("lumiBlocks missing from FileMetaData")
+    except (KeyError,):
+        logAutoConfiguration.verbose("lumiBlocks missing from FileMetaData")
     try:
         if len(lbs)>1:
-            logAutoConfiguration.warning("Data from more than one lumi-block "
+            logAutoConfiguration.verbose("Data from more than one lumi-block "
                                          "in the same file. Use first "
                                          "lumi-block number.")
     except (TypeError,):
-        logAutoConfiguration.warning("No LumiBlock number stored in InputFile!"
-                                     " Use None")
+        logAutoConfiguration.verbose("No LumiBlock number stored in InputFile!"
+                                     " Returning 'None'")
         return None
     try:
         lb = lbs[0]
-        logAutoConfiguration.debug("LumiBlock Number is: %i",lb)
-        return lb
     except (IndexError,):
-        logAutoConfiguration.warning("No LumiBlock number stored in InputFile!"
-                                     " Use None")
-    return None
+        logAutoConfiguration.verbose("No LumiBlock number stored in InputFile!"
+                                     " Returning 'None'")
+        lb = None
+    logAutoConfiguration.debug(f"LumiBlock Number is: {lb}")
+    return lb
 
 
 def GetFieldFromCool():
-- 
GitLab