Skip to content

GitLab

Merged
Created by Tim Martin@tamartinDeveloper

Remove MergeIntoSuperRoI from InputMakerForROI

As spotted by @sutt

Remove the MergeIntoSuperRoI option before anyone goes and uses it.

This flag was not a good addition as it (mildly...) breaks a tenant of the InputMaker that the ROIs communicated to the step's reconstruction algs (by virtue of the transient RoIs container) should be direct copies of the (persistent, navigation-registered) ROIs which were chosen per DecisionObject by the supplied ROITool

Should in future we need to feed more than 1 ROI to a reco alg which only accepts <= 1 ROI, then we either:

  • Rewrite the reco alg to accept >1 ROI
  • Change the InputMaker's ROITool to a new one which does the SuperROI creation inside the Tool. Hence the superROI is then also the persistent, navigation-registered ROI.