Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 128
    • Merge requests 128
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !50658

Make fastjet::Filter a local variable to avoid cross-event state

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Teng Jian Khoo requested to merge khoo/athena:master-JetRec-TrimmingMT into master Feb 21, 2022
  • Overview 3
  • Commits 2
  • Pipelines 1
  • Changes 3

As discussed on ATR-22142, the fastjet::Filter member variable in the JetTrimming class could hold state across multiple jets and multiple events, which is a serious multithreading risk and could be a cause of the regular segfaults seen in trimming. This class being lightweight, we should be able to afford generating a new Filter for every jet requiring trimming, and thereby avoid any state retention.

Incidentally simplified retrieval of jets from DataVector after emplace_back.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master-JetRec-TrimmingMT