Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 143
    • Merge requests 143
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !51950

Merged
Created Apr 05, 2022 by Christos Anastopoulos@christosDeveloper

Try to introduce for ITimedMatEffUpdator, the same interface as IMaterialEffectsUpdator. Return unique_ptr to non-const Parameters

  • Overview 14
  • Commits 3
  • Pipelines 2
  • Changes 6

Try to introduce for ITimedMatEffUpdator, the same interface as IMaterialEffectsUpdator. Return unique_ptr to non-const Parameters. see https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Tracking/TrkExtrapolation/TrkExInterfaces/TrkExInterfaces/IMaterialEffectsUpdator.h

This seemed the cleanest way to handle onwership at least in the way we did it for the other tracking tools.

ping @sroe, @jchapman , @tcuhadar

Ps: On top of "ownership" and revisiting the leaks after this step. One question is if we want to have a cache also here... as the McMaterialEffects is not MT-safe as at least it reads while [Tracking/TrkExtrapolation/TrkExTools/TrkExTools/MaterialEffectsUpdator.h] is

Edited Apr 05, 2022 by Christos Anastopoulos
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: ITimedMaterialEffectsUpdator_return_unique_ptr