Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 137
    • Merge requests 137
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !53414

Further fixes for TileSamplingFractionCondAlg configuration

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged John Derek Chapman requested to merge jchapman/athena:FixPythonWarningTileConditions_master into master May 18, 2022
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 1

This should hopefully fix the CI failures caused by the typo fix in !53398 (merged).

I'm going to enable full unit tests on this one to avoid another round of 'whack-a-mole' hopefully.

The current situation is that the TileSamplingFraction conditions are being taken from a file for digi/MC reco now I think. The G4Version was being correctly determined from the input file metadata, but the version from the conditions file seems to be more like the sampling fraction than a Geant4 version.

Geant4 simulation version (10.01) is not compatible with version used to calculate Tile SF (0.34)

In this MR, I've suppressed the comparison of the conditions G4Version in this case again. The output doesn't change, so this must reproduce the previous behaviour.
It would be nicer if digi/reco could take the sampling fraction conditions from COOL, as I had originally intended in !52397 (merged), but this seemed to cause problems for a number of unit tests in the TileByteStream and TileRecUtils packages.

It probably needs someone more familiar with the TileCalorimeter code to make this next step (assuming it makes sense). @harkusha could you comment please?

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: FixPythonWarningTileConditions_master