Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 154
    • Merge requests 154
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !53541

Closed
Created May 20, 2022 by Christos Anastopoulos@christosDeveloper
  • Report abuse
Report abuse

EGammaVariableCorrection fix thread safety warnings

  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 2

Just pass the variable as extra arguement between the method rather than mutating a member.

Should fix one of the issues identified for [!53506 (merged)]

[ 84%] Building CXX object Reconstruction/Jet/JetRec/CMakeFiles/JetRecLib.dir/Root/JetConstituentsRetriever.cxx.o
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/PhysicsAnalysis/ElectronPhotonID/EGammaVariableCorrection/Root/ElectronPhotonVariableCorrectionBase.cxx: In member function 'const StatusCode ElectronPhotonVariableCorrectionBase::setCorrectionParameters(float, float, float) const':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/PhysicsAnalysis/ElectronPhotonID/EGammaVariableCorrection/Root/ElectronPhotonVariableCorrectionBase.cxx:713:46: warning: Function 'const StatusCode ElectronPhotonVariableCorrectionBase::setCorrectionParameters(float, float, float) const' calling non-const function 'virtual void TF1::SetParameter(Int_t, Double_t)' via member pointer/reference 'ElectronPhotonVariableCorrectionBase::m_correctionFunctionTF1'; may not be thread-safe
  713 |         m_correctionFunctionTF1->SetParameter(parameter_itr,properties.at(parameter_itr))

ping @psommer @jdevivi

Edited May 20, 2022 by Christos Anastopoulos
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: ElectronPhotonVariableCorrection_stricter_Checker