Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • athena athena
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Jira
    • Jira
  • Merge requests 137
    • Merge requests 137
  • Deployments
    • Deployments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Issue
    • Repository
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • atlas
  • athenaathena
  • Merge requests
  • !54627

Unification of GSF and non GSF chain configuration

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Fernando Monticelli requested to merge fernando/athena:UnifyGSF into 22.0 Jun 29, 2022
  • Overview 26
  • Commits 5
  • Pipelines 3
  • Changes 5

This addresses part of ATR-24210.

Here am unifying Electron/PrecisionElectronRecoSequences_GSF.py into Electron/PrecisionElectronRecoSequences.py.

The "variant" logic I originally introduced when I unified LRT (before GSF) does make sense now, so am just puting in flags to define whether we are activating HI or LRT or GSF.

Work still need to be done to unify PrecisionElectronMenuSequences_GSF.py but I'll do that in a separated MR to make it easier to review.

This is discussed in ATR-24210 and ATR-24211

Pinging @cjmeyer @safarzad and @dbakshig

Edited Jul 25, 2022 by Fernando Monticelli
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: UnifyGSF