From ca58c534788f626797cd2d528979acbd9071b219 Mon Sep 17 00:00:00 2001
From: sss <sss@karma>
Date: Thu, 31 Oct 2024 12:25:18 -0400
Subject: [PATCH] MuonCalibSegmentCreator: Fix cppcheck warnings.

Null pointer check cleanups.
---
 .../MuonCalibSegmentCreator/src/MuonSegmentReader.cxx          | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/src/MuonSegmentReader.cxx b/MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/src/MuonSegmentReader.cxx
index d13e95428024..f1492ffe6546 100644
--- a/MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/src/MuonSegmentReader.cxx
+++ b/MuonSpectrometer/MuonCalib/MuonCalibSegmentCreator/src/MuonSegmentReader.cxx
@@ -309,6 +309,7 @@ void MuonSegmentReader::storeMeasurement(const EventContext& ctx, const MuonGM::
       const MuonGM::MdtReadoutElement* detEl = MuonDetMgr->getMdtReadoutElement(id);
       if( !detEl ) {
         ATH_MSG_WARNING( "getGlobalToStation failed to retrieve detEL byebye"  );
+        return;
       }
 
       // get the 2nd coordinator from the track hit measurement
@@ -342,7 +343,7 @@ void MuonSegmentReader::storeMeasurement(const EventContext& ctx, const MuonGM::
       // residual calculator  
       float residualBiased = -999.;
       float pullBiased = -999.;
-      if( trackPars ) {
+      {
         std::optional<Trk::ResidualPull> resPullBiased = m_pullCalculator->residualPull(measurement, trackPars, Trk::ResidualPull::Biased );
         if(resPullBiased.has_value()){
           residualBiased = resPullBiased.value().residual().front();
-- 
GitLab