Define non-const surface method and change CachedUniquePtr to CachedUniquePtrT to fix ATLASRECTS-4957.
Define non-const surface method and change CachedUniquePtr to CachedUniquePtrT to fix ATLASRECTS-4957.
This MR replaces MR !23535 (closed).
Merge request reports
Activity
mentioned in merge request !23535 (closed)
added InnerDetector master review-pending-level-1 labels
✅ CI Result SUCCESSAthena AthSimulation externals ✅ ✅ cmake ✅ ✅ make ✅ ✅ required tests ✅ ✅ optional tests ✅ ✅ Full details available at NICOS MR-23540-2019-05-19-23-39
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST 38667]changed title from Define non-const surface method and change UniqueCachedPrt to UniquePtrT to fix ATLASRECTS-4957. to Define non-const surface method and change CachedUniquePtr to CachedUniquePtrT to fix ATLASRECTS-4957.
added 1 commit
- 1f940a1b - Move std::move to the setTrackQualityCuts method
added 1 commit
- 1be3c760 - Define non-const surface method. Change UniqueCachedPrt to UniquePtrT.
✅ CI Result SUCCESSAthena AthSimulation externals ✅ ✅ cmake ✅ ✅ make ✅ ✅ required tests ✅ ✅ optional tests ✅ ✅ Full details available at NICOS MR-23540-2019-05-20-09-54
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST 38676]AthSimulation seems to build ok here or has the problematic change from !23535 (closed) not been included?
Hi @jchapman,
Yes, a different change was tried not to affect AthSimulation and succeeded.
Cheers, Susumu
added review-approved label and removed review-pending-level-1 label
✅ CI Result SUCCESSAthena AthSimulation externals ✅ ✅ cmake ✅ ✅ make ✅ ✅ required tests ✅ ✅ optional tests ✅ ✅ Full details available at NICOS MR-23540-2019-05-20-11-55
✅ Athena: number of compilation errors 0, warnings 0
✅ AthSimulation: number of compilation errors 0, warnings 0
📝 For experts only: Jenkins output [CI-MERGE-REQUEST 38675]mentioned in commit 2c6e8ba4
mentioned in merge request !23560 (merged)
added sweep:ignore label