Skip to content
Snippets Groups Projects

AMH-115: Fix EXOT27 b-tagging in pflow and GhostTag VR track jets

Merged AMH-115: Fix EXOT27 b-tagging in pflow and GhostTag VR track jets
Merged Dan Guest requested to merge dguest/athena:smart-slim-ghosttag into 21.2

The AntiKtVR30Rmax4Rmin02TrackGhostTagJets and AntiKt4EMPFlowJets were both pretty broken since they didn't include a b-tagging link and we weren't saving the corresponding btagging object. So we wanted to do a few things:

  • Add b-tagging back
  • Add a lot more variables that will be inputs to an Xbb tagger
  • Keep the derivation the same size or smaller

So I've done a few things here:

  • Add the b-tagging object to jet collections
  • Schedule pflow b-tagging in this derivation (it wasn't being built before)
  • Used a smart slimming list for GhostTag VR track jets that includes an additional 20 or so Xbb taging input variables.
  • Used a smart slimming list for the GhostTag jets, previously we were adding them to AllVariables. This list is just the bare jet collection, I don't think we need anything else.
  • Thin the GhostTag jets and associated b-tagging objects with @jburr's awesome link thinning tool.
    • I only save these jets if they are associated to a Large-R jet over 100 GeV
    • I'd consider going higher here but probably only if the we're thinning on are calibrated

The smart slimming list together with the added b-tagging variables means that we're actually saving slightly fewer variables per jet than we were before. In addition the link thinning reduces the number of jets we save to 1/3rd in the test I looked at (whatever the derivation framework uses for an MC file).

Also pinging @sargyrop, @eskorda. I think this is pretty much final but again we should run a few more tests before we merge / request a new cache.

Edited by Dan Guest

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Dan Guest added 13 commits

    added 13 commits

    • aa1bc7c0...b2403ca0 - 10 commits from branch atlas:21.2
    • 91081e41 - Guard MCTruthCommon import
    • 75115515 - Merge remote-tracking branch 'jon/MCTruthCommonFix' into smart-slim-ghosttag
    • 76551c1a - Add call to FlavorTagInit for pflow jets

    Compare with previous version

  • Dan Guest unmarked as a Work In Progress

    unmarked as a Work In Progress

  • Dan Guest changed the description

    changed the description

  • This merge request affects 3 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkExotics
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag

    Adding @rcreager ,@bdong ,@sanmay as watchers

  • CI Result SUCCESS

    AnalysisBase AnalysisTop AthAnalysis AthDerivation
    externals
    cmake
    make
    required tests
    optional tests

    Full details available at NICOS MR-25104-2019-07-25-12-56
    AnalysisBase: number of compilation errors 0, warnings 0
    AnalysisTop: number of compilation errors 0, warnings 0
    AthAnalysis: number of compilation errors 0, warnings 0
    AthDerivation: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST 40075]

  • Dan Guest added 1 commit

    added 1 commit

    Compare with previous version

  • Dan Guest resolved all discussions

    resolved all discussions

  • This merge request affects 3 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkCore
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkExotics
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkFlavourTag

    Adding @rcreager ,@bdong ,@sanmay as watchers

  • CI Result SUCCESS

    AnalysisBase AnalysisTop AthAnalysis AthDerivation
    externals
    cmake
    make
    required tests
    optional tests

    Full details available at NICOS MR-25104-2019-07-25-15-56
    AnalysisBase: number of compilation errors 0, warnings 0
    AnalysisTop: number of compilation errors 0, warnings 0
    AthAnalysis: number of compilation errors 0, warnings 0
    AthDerivation: number of compilation errors 0, warnings 0
    📝 For experts only: Jenkins output [CI-MERGE-REQUEST 40079]

  • Dan Guest changed title from AMH-115: Smart slim ghosttag jet collection to AMH-115: Fix EXOT27 b-tagging in pflow and GhostTag VR track jets

    changed title from AMH-115: Smart slim ghosttag jet collection to AMH-115: Fix EXOT27 b-tagging in pflow and GhostTag VR track jets

  • Dan Guest changed the description

    changed the description

  • added bugfix label

  • Author Developer

    marking as urgent since we definitely want this in the next derivation cache

  • added urgent label

  • The changes look ok. Since this MR changes derivation output, I pass this to L2 shifters.

    L1 shifter

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading