Skip to content
Snippets Groups Projects

adding new PLVLoose/Tight definition

Closed Shunichi Akatsuka requested to merge sakatsuk/athena:PLTstudies into 21.2

Trying to add new isolation WPs based on PromptLeptonVeto score, and the low-pt version of it (we call it LowPtPLV). There are major updates because we needed to add LowPtPLT in IsolationSelection package, as they are not currently calculated at derivation level.

Presentation about the final WP definition and its performance: https://indico.cern.ch/event/851820/contributions/3581694/attachments/1917246/3170461/IFF_20190930_PLVWP.pdf

Discussion on LowPtPLV: https://indico.cern.ch/event/848448/contributions/3564603/attachments/1908395/3152628/20190916_akatsuka_PLT.pdf

Sorry the codes are still quite dirty, submitting this MR to start the discussion... tagging @maklein @oducu @shion @rustem

Edited by Shunichi Akatsuka

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
9 #include <AsgTools/AnaToolHandle.h>
10 #include <IsolationSelection/IIsolationLowPtPLVTool.h>
11 #include <vector>
12 #include <string>
13
14 // TMVA
15 #include "TMVA/Reader.h"
16
17 namespace CP {
18 class IsolationLowPtPLVTool: public asg::AsgTool, public virtual IIsolationLowPtPLVTool {
19
20 public:
21 IsolationLowPtPLVTool(const std::string& name);
22 ASG_TOOL_CLASS(IsolationLowPtPLVTool, IIsolationLowPtPLVTool)
23 virtual StatusCode initialize();
24 StatusCode AugmentPLV(xAOD::IParticle* Particles) const;
  • Why aren't the methods present in the interface class itself? Thus far the interface is empty

  • Fixed. The methods are all in the interface class, AugmentPLV().

  • What interface class?

    This "tool" class is just all kinds of wrong. :frowning: You shouldn't make a class inherit from asg::AsgTool if it doesn't implement a proper pure-virtual interface. And this class really doesn't.

    At first I thought that this may be a (scary) pattern already present in this package. But thankfully that doesn't seem to be the case.

    I also don't understand how the changes in IsolationSelectionTool.cxx relate to this new class. Though that may be just my own lack of understanding.

    Normally at this point I'd ask for a talk/discussion about this in an ASG meeting. But with those absent at the moment, I guess we have to follow up like this. Which will take a bit longer than just discussing live... :frowning:

  • Okay, now I'm super confused. :confused:

    In the "changes view" I don't see the class inheriting from any interfaces. But in the "discussion view" I do. Eh? :confused:

  • Please register or sign in to reply
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading