Skip to content

CMake Version Updates, 1.0 branch (2018.10.09.)

Attila Krasznahorkay requested to merge akraszna/atlasexternals:CMakeVersionUpdates-1.0-20181009 into 1.0

While fixing the "TIMESTAMP issue" with !357 (merged), I realised that we should clean up the requested CMake versions a bit.

You see, the "%s" argument of string(TIMESTAMP) was only introduced in CMake version 3.6.

https://gitlab.kitware.com/cmake/cmake/commit/6727270b75eec4e379acd4a39f5003a316249c73

(Click on "parent" to see all the tags/branches that this code is part of.) So I updated all projects to require at least CMake 3.6.

At the same time, as long as I was doing this, I added an extra requirement to Externals/HDF5. Since the HDF5 build actually requires CMake 3.10 as the minimum. Which annoyed me a few times in the past when trying to build AnalysisBase on Ubuntu-16.04, which provides CMake 3.5 by default (if I remember correctly...).

I did test that I was able to build AthenaExternals with CMake-3.6.3, so the 3.6 requirement seems appropriate.

Merge request reports