Skip to content

CheckerGccPlugins: New/missed warnings

Scott Snyder requested to merge ssnyder/atlasexternals:coral.CheckerGccPlugins-20200326 into master

  • Warn about potentially unsafe uses of coral::AttributeList.

  • Constructors and destructors were not being fully checked. Fixed.

  • The thread-safety checker verifies that when virtual functions are overridden, they have compatible threading attributes. However, in some cases involving multiple inheritance, this check was being skipped. Fixed.

  • Warn about derivation from Gaudi::Algorithm in addition to Algorithm.

  • Fix some errors in the documentation.

This has the potential to uncover new warnings in the Athena build. All new warnings encountered so far have been fixed already, but there may still be others. We should probably go ahead with this merge even if there are some new warnings in master, as long as there are not too many (a dozen or so).

Merge request reports