Skip to content

Static checker updates.

Scott Snyder requested to merge ssnyder/atlasexternals:dict2.CheckerGccPlugins-20221003 into master
  • Skip checking of _rootcint.cxx files.
  • Replace the hardcoded list of directory names for code that is to be considered thread-safe with a configuration parameter.
  • For warnings about calling non-const methods via a pointer member from a const method, realize that unique_ptr::get() also returns the pointer. Treat it like operator->. Also fix an issue with suppressing this warning for unique_ptr.
  • Don't warn about overriding the non-const execute() method of Algorithm with a non-thread-safe method.
  • Fix warning suppression for ctor calls.
  • Remove references to ATLAS_CTORDOR_NOT_THREAD_SAFE workaround.
  • Warn about writing via a pointer member in a const member function.

The last of these generates some new warnings. I've fixed all that i've seen, but it's possible that there may be others.

cc Frank and Christos. (@fwinkl @christos )

Merge request reports