Rename minTolerance option to avoid confusion with meaning of tolerance in RooFit
Hello,
In reviewing a recent analysis, some confusion come up around the meaning of the "Tolerance" setting the analysis team were using. They said they were using a "Tolerance" of 0.005, which seems perfectly reasonable to me. However, it turned out that setting was what they were passing to quickFit's --minTolerance command, and in the code https://gitlab.cern.ch/atlas_higgs_combination/software/quickFit/-/blob/main/src/fitTool.cxx?ref_type=heads#L270 we can see that the value of that thing gets multiplied by 1000 before being passed onto the minimizer.
I understand the reason for the quickFit rescaling is because the tolerance setting (in RooFit) is converted into a max-edm threshold by dividing the tolerance by 1000, i.e. a tolerance of 5 would translate to a max-edm of 0.005.
But would you be able to change the name of this option so that you don't call it minTolerance, so that we don't have confusion in future when talking about Tolerance. Perhaps could you change the name of the option to maxEDM or something like that, which would be unambiguous and in fact more informative than the name "Tolerance" anyway.
What do you think?