@hawu FYI
@cagapopo Thanks for the reminder, I will have less time during the YETS, but I will do my best
Basem Khanji (4ed79ea2) at 14 Sep 17:18
Fixed formatting
Basem Khanji (ec0e4dc7) at 14 Sep 17:14
Update UTDecoder.h comment the formula used to return the ADC word ...
any thing else to address ? can we merge ?
any thing else to address ? can we merge ?
any thing else to address ? can we merge ?
Boole!506 (merged) is understood and merged now, Could we merge this, any other issues to solve?
cc @ganowak
Basem Khanji (005278cb) at 02 Aug 22:08
Basem Khanji (142bc05a) at 02 Aug 22:08
@rmatev so what do you think ?
Okay things look great, Moore tests (in DD4Hep) are OK, the detdesc mode test failures are understood, they are related to LHCb!4168 (merged) & Rec!3496 (merged) (check my comment here: Rec!3496 (comment 6967751), the Bool failures are not expected to me, but I do not think they are caused by my change in this MR because these falling tests are not using Allen algos. in any way.
Basem Khanji (ef90f969) at 01 Aug 18:53
When the Boole encoder is ready we will fix this bit of code indeed
@jagoodin : Issues in the corresponding nightlies are coming from a bug in Rec, LHCb, it was fixed already LHCb!4168 (merged) , can we test again and hopefully merge ?