bug #72215: Remove the TAPEGATEWAYREQUEST table from the schema, and drop the...

bug #72215: Remove the TAPEGATEWAYREQUEST table from the schema, and drop the triggers that populate it.

Fixed synthax.

test/tapegateway_release_tests/CastorTapeTests.pm

@@ -156,9 +156,9 @@ sub check_migrated ( $ )
     my $file_name = shift;
     my $nsls=`nsls $file_name`;
     if ($nsls=~ /^([\w-]+)\s+(\d+)\s+(\w+)\s+(\w+)\s+(\d+)/ ) {
-        return ('m' eq substr ($1,0,1)) || $5 = 0;
+        return ( ('m' eq substr ($1,0,1)) || ($5 == 0) );
     } else {
-        die "Failed to find file $remote_files[$file_index]";
+        die "Failed to find file $file_name";
     }
 }
 
@@ -282,8 +282,8 @@ sub check_remote_entries ()
             die "Entry not found in name server: $entry{name}";
         }
         # if it's a file, check the migration status
-        if ( %entry{type} eq "file" ) {
-            if ( %entry{status} eq "rfcpied" ) {
+        if ( $entry{type} eq "file" ) {
+            if ( $entry{status} eq "rfcpied" ) {
                 if ( check_migrated (  $entry{name} ) ) {
                     $remote_files[$i]->{status} = "migrated";
                     $changed_entries ++;
@@ -1302,7 +1302,7 @@ END {
     print "In CastorTapeTests::END: calling cleanup\n";
     cleanup();
     print "Cleanup complete. Printing leftovers.\n";
-    my $bdh = open_db();
+    my $dbh = open_db();
     print_leftovers ($dbh);
     $dbh->disconnect();
     print "End of leftovers\n";

test/tapegateway_release_tests/test_gateway_wipe_reinstall_migrate.pl

@@ -98,10 +98,10 @@ sub main ()
     # Re-create the directories:
     print `su $username -c "nsmkdir $castor_directory$single_subdir"`;
     print `su $username -c "nschclass largeuser $castor_directory$single_subdir"`;
-    CastorTapeTests::register_remote ( $castor_directory$single_subdir, "directory" );
+    CastorTapeTests::register_remote ( $castor_directory.$single_subdir, "directory" );
     print `su $username -c "nsmkdir $castor_directory$dual_subdir"`;
     print `su $username -c "nschclass test2 $castor_directory$dual_subdir"`;
-    CastorTapeTests::register_remote ( $castor_directory$dual_subdir, "directory" );
+    CastorTapeTests::register_remote ( $castor_directory.$dual_subdir, "directory" );
     
     
     # First iteration of the test