diff --git a/FaserGeometryCommon/TrenchGeoModel/src/TrenchDetectorFactory.cxx b/FaserGeometryCommon/TrenchGeoModel/src/TrenchDetectorFactory.cxx
index c2dcc9b2201c4441f0ec5fbe92fccb4177dd5d74..da787acdfc58391b7cd3f68b00b7aae5f1055a91 100644
--- a/FaserGeometryCommon/TrenchGeoModel/src/TrenchDetectorFactory.cxx
+++ b/FaserGeometryCommon/TrenchGeoModel/src/TrenchDetectorFactory.cxx
@@ -62,20 +62,20 @@ void TrenchDetectorFactory::create(GeoPhysVol *world)
std::string resolvedFile = PathResolver::find_file(gdmlFile, "XMLPATH", PathResolver::RecursiveSearch);
auto store = XMLHandlerStore::GetHandlerStore();
- for (auto p : *store)
- {
- delete p.second;
- }
+ // for (auto p : *store)
+ // {
+ // delete p.second;
+ // }
store->clear();
GDMLController controller {"TrenchGDMLController"};
- std::cout << "creating parser" << std::endl;
+ // std::cout << "creating parser" << std::endl;
XercesParser xercesParser;
- std::cout << "parsing " << resolvedFile << std::endl;
+ // std::cout << "parsing " << resolvedFile << std::endl;
xercesParser.ParseFileAndNavigate(resolvedFile);
- std::cout << "done parsing " << resolvedFile << std::endl;
+ // std::cout << "done parsing " << resolvedFile << std::endl;
const GeoLogVol* trenchLog = controller.retrieveLogicalVolume("Trench").first;
GeoPhysVol* trenchPhys = new GeoPhysVol(trenchLog);
diff --git a/FaserGeometryCommon/TrenchGeoModel/src/TrenchDetectorTool.cxx b/FaserGeometryCommon/TrenchGeoModel/src/TrenchDetectorTool.cxx
index cfd2b94f43cc4fc0202b1e8af1ddee7a98700564..c036496ea42cef602db10a0190367d97ff25e3a3 100644
--- a/FaserGeometryCommon/TrenchGeoModel/src/TrenchDetectorTool.cxx
+++ b/FaserGeometryCommon/TrenchGeoModel/src/TrenchDetectorTool.cxx
@@ -45,13 +45,11 @@ StatusCode TrenchDetectorTool::create()
}
DecodeFaserVersionKey versionKey(geoDbTag,"Trench");
- IRDBRecordset_ptr switchSet
- = raccess->getRecordsetPtr("TrenchSwitches", versionKey.tag(), versionKey.node(),"FASERDD");
- const IRDBRecord *switches = (*switchSet)[0];
- msg(MSG::DEBUG) << "Retrieved TrenchSwitches" << endmsg;
+ // IRDBRecordset_ptr switchSet
+ // = raccess->getRecordsetPtr("TrenchSwitches", versionKey.tag(), versionKey.node(),"FASERDD");
+ // const IRDBRecord *switches = (*switchSet)[0];
+ // msg(MSG::DEBUG) << "Retrieved TrenchSwitches" << endmsg;
-
-// std::string trenchVersion = geoDbTag->trenchVersion();
std::string trenchVersion = versionKey.tag();
msg(MSG::INFO) << "Building Trench geometry version " << trenchVersion << endmsg;
if(trenchVersion.empty()) {
diff --git a/Tracker/TrackerRecAlgs/TrackSeedPerformanceWriter/src/TrackSeedPerformanceWriter.cxx b/Tracker/TrackerRecAlgs/TrackSeedPerformanceWriter/src/TrackSeedPerformanceWriter.cxx
index 9c43a4e2a1bffc98af9c2fdd49385ddfaac0f2f9..cc0df45c1115acf86eab441652e420953aef8280 100644
--- a/Tracker/TrackerRecAlgs/TrackSeedPerformanceWriter/src/TrackSeedPerformanceWriter.cxx
+++ b/Tracker/TrackerRecAlgs/TrackSeedPerformanceWriter/src/TrackSeedPerformanceWriter.cxx
@@ -8,7 +8,7 @@ namespace Tracker {
TrackSeedPerformanceWriter::TrackSeedPerformanceWriter(const std::string &name, ISvcLocator *pSvcLocator)
: AthReentrantAlgorithm(name, pSvcLocator), AthHistogramming(name),
- m_idHelper(nullptr), m_histSvc("THistSvc/THistSvc", name) {}
+ m_histSvc("THistSvc/THistSvc", name), m_idHelper(nullptr){}
StatusCode TrackSeedPerformanceWriter::initialize() {
diff --git a/Tracker/TrackerRecAlgs/TrackerData/src/TrackerSegmentFitDataAlg.cxx b/Tracker/TrackerRecAlgs/TrackerData/src/TrackerSegmentFitDataAlg.cxx
index 92545f3202a58880bbfb6ec6cfa55e3a0bc4396f..d6666a34b3ffddd84d8f215ff5f895439862504b 100644
--- a/Tracker/TrackerRecAlgs/TrackerData/src/TrackerSegmentFitDataAlg.cxx
+++ b/Tracker/TrackerRecAlgs/TrackerData/src/TrackerSegmentFitDataAlg.cxx
@@ -13,7 +13,7 @@ namespace Tracker {
TrackerSegmentFitDataAlg::TrackerSegmentFitDataAlg(const std::string &name, ISvcLocator *pSvcLocator)
: AthReentrantAlgorithm(name, pSvcLocator), AthHistogramming(name),
- m_detMgr(nullptr), m_idHelper(nullptr), m_histSvc("THistSvc/THistSvc", name) {}
+ m_histSvc("THistSvc/THistSvc", name), m_detMgr(nullptr), m_idHelper(nullptr) {}
StatusCode TrackerSegmentFitDataAlg::initialize() {
diff --git a/Tracker/TrackerRecAlgs/TrackerData/src/TrackerTruthDataAlg.cxx b/Tracker/TrackerRecAlgs/TrackerData/src/TrackerTruthDataAlg.cxx
index 188f8afb930a7c8006561076d582e2b685da4692..0f3c8afe610ce69417d5acb2b1b0680b7f7c5ffc 100644
--- a/Tracker/TrackerRecAlgs/TrackerData/src/TrackerTruthDataAlg.cxx
+++ b/Tracker/TrackerRecAlgs/TrackerData/src/TrackerTruthDataAlg.cxx
@@ -11,7 +11,7 @@ namespace Tracker {
TrackerTruthDataAlg::TrackerTruthDataAlg(const std::string &name, ISvcLocator *pSvcLocator)
: AthReentrantAlgorithm(name, pSvcLocator), AthHistogramming(name),
- m_sct(nullptr), m_sID(nullptr), m_histSvc("THistSvc/THistSvc", name) {}
+ m_histSvc("THistSvc/THistSvc", name), m_sct(nullptr), m_sID(nullptr) {}
StatusCode TrackerTruthDataAlg::initialize() {
diff --git a/Tracker/TrackerRecAlgs/TrackerSegmentFit/src/SegmentFitAlg.h b/Tracker/TrackerRecAlgs/TrackerSegmentFit/src/SegmentFitAlg.h
index 757eb1a22752acbe72e0da7a0c6c7a89878bf76a..bce869119f8a4927ddc272d885aa3cffe6c46ea1 100644
--- a/Tracker/TrackerRecAlgs/TrackerSegmentFit/src/SegmentFitAlg.h
+++ b/Tracker/TrackerRecAlgs/TrackerSegmentFit/src/SegmentFitAlg.h
@@ -415,7 +415,7 @@ class SegmentFitAlg : public AthReentrantAlgorithm
DoubleProperty m_tanThetaCut { this, "TanThetaCut", 0.0, "Maximum accepted tangent of track angle from beam axis; 0 means no cut."};
DoubleProperty m_reducedChi2Cut { this, "ReducedChi2Cut", 10.0, "Maximum accepted chi^2 per degree of freedom for final fits; 0 means no cut." };
DoubleProperty m_sharedHitFraction { this, "SharedHitFraction", -1., "Fraction of hits which are allowed to be shared between two fits." };
- IntegerProperty m_minClustersPerFit { this, "MinClustersPerFit", 4, "Minimum number of clusters a fit has to have." };
+ UnsignedIntegerProperty m_minClustersPerFit { this, "MinClustersPerFit", 4, "Minimum number of clusters a fit has to have." };
mutable std::atomic<int> m_numberOfEvents{0};
mutable std::atomic<int> m_numberExcessOccupancy{0};
diff --git a/Tracker/TrackerRecAlgs/TrackerTruth/src/TrackerTruthAlg.cxx b/Tracker/TrackerRecAlgs/TrackerTruth/src/TrackerTruthAlg.cxx
index cc600bad74f6e16341757becc305ea0343416889..84249c0cc4e2bde1dd54bf7192f0fbc67295c189 100644
--- a/Tracker/TrackerRecAlgs/TrackerTruth/src/TrackerTruthAlg.cxx
+++ b/Tracker/TrackerRecAlgs/TrackerTruth/src/TrackerTruthAlg.cxx
@@ -10,7 +10,7 @@ namespace Tracker {
TrackerTruthAlg::TrackerTruthAlg(const std::string &name, ISvcLocator *pSvcLocator)
: AthReentrantAlgorithm(name, pSvcLocator), AthHistogramming(name),
- m_sct(nullptr), m_sID(nullptr), m_histSvc("THistSvc/THistSvc", name) {}
+ m_histSvc("THistSvc/THistSvc", name), m_sct(nullptr), m_sID(nullptr) {}
StatusCode TrackerTruthAlg::initialize() {
diff --git a/Tracker/TrackerRecAlgs/TruthSeededTrackFinder/src/TruthSeededTrackFinder.cxx b/Tracker/TrackerRecAlgs/TruthSeededTrackFinder/src/TruthSeededTrackFinder.cxx
index c88414a505231ab1fee984801da34f83982394ce..f0a7b64cd20c02d0e13a5357b9fe3f05f36f6f5a 100755
--- a/Tracker/TrackerRecAlgs/TruthSeededTrackFinder/src/TruthSeededTrackFinder.cxx
+++ b/Tracker/TrackerRecAlgs/TruthSeededTrackFinder/src/TruthSeededTrackFinder.cxx
@@ -312,11 +312,11 @@ namespace Tracker
// depositPair.first->print(std::cout);
// std::cout<<"!!!!!!!!!!! pdg id = "<<depositPair.first->pdg_id()<<std::endl;
if (depositPair.first->pdg_id() == -13) {
- HepMC::FourVector pv = depositPair.first->production_vertex()->position();
- HepMC::FourVector ev = depositPair.first->end_vertex()->position ();
+ // HepMC::FourVector pv = depositPair.first->production_vertex()->position();
+ // HepMC::FourVector ev = depositPair.first->end_vertex()->position ();
truthmom = depositPair.first->momentum();
-// std::cout<<"!!!!!!!!!!! production_vertex: ( "<<pv.x()<<", "<<pv.y()<<", "<<pv.z()<<" ) "<<std::endl;
-// std::cout<<"!!!!!!!!!!! end_vertex: ( "<<ev.x()<<", "<<ev.y()<<", "<<ev.z()<<" ) "<<std::endl;
+ // std::cout<<"!!!!!!!!!!! production_vertex: ( "<<pv.x()<<", "<<pv.y()<<", "<<pv.z()<<" ) "<<std::endl;
+ // std::cout<<"!!!!!!!!!!! end_vertex: ( "<<ev.x()<<", "<<ev.y()<<", "<<ev.z()<<" ) "<<std::endl;
}
//!!!!!!!!!!!!!!!!!!!!!!!!
if( depositPair.second > highestDep)
@@ -338,14 +338,14 @@ namespace Tracker
for (auto daughter : primary->particles_out())
{
// TODO: Check that daughter->production_vertex() and daughter->end_vertex() exist, and bracket the point you're interested in
- if (daughter->barcode() % 1000000 == primary->barcode()) {
+ if (daughter->barcode() % 1000000 == primary->barcode()) {
ATH_MSG_DEBUG(" daughter barcode: " << daughter->barcode() << " with energy " << daughter->momentum().e() << " px = " << daughter->momentum().px() << " py = " << daughter->momentum().py() << " pz = " << daughter->momentum().pz() );
- if (daughter->production_vertex() != nullptr && daughter->end_vertex() != nullptr) {
- HepMC::FourVector pv = daughter->production_vertex()->position();
- HepMC::FourVector ev = daughter->end_vertex()->position ();
-// std::cout<<"!!!!!!!!!!! production_vertex: ( "<<pv.x()<<", "<<pv.y()<<", "<<pv.z()<<" ) "<<std::endl;
-// std::cout<<"!!!!!!!!!!! end_vertex: ( "<<ev.x()<<", "<<ev.y()<<", "<<ev.z()<<" ) "<<std::endl;
- }
+ // if (daughter->production_vertex() != nullptr && daughter->end_vertex() != nullptr) {
+ // HepMC::FourVector pv = daughter->production_vertex()->position();
+ // HepMC::FourVector ev = daughter->end_vertex()->position ();
+ // std::cout<<"!!!!!!!!!!! production_vertex: ( "<<pv.x()<<", "<<pv.y()<<", "<<pv.z()<<" ) "<<std::endl;
+ // std::cout<<"!!!!!!!!!!! end_vertex: ( "<<ev.x()<<", "<<ev.y()<<", "<<ev.z()<<" ) "<<std::endl;
+ // }
}
}
}
@@ -533,11 +533,11 @@ namespace Tracker
// std::cout<<"!!!!!!!!!!! direct2 = ("<<direct2.x()<<", "<<direct2.y()<<", "<<direct2.z()<<") "<<std::endl;
// the vector pointing from the center of circle to the particle at layer 2 in Y-Z plane
double R1_z = charge * direct1.y() / std::sqrt(direct1.y()*direct1.y() + direct1.z()*direct1.z());
- double R1_y = -charge * direct1.z() / std::sqrt(direct1.y()*direct1.y() + direct1.z()*direct1.z());
+ // double R1_y = -charge * direct1.z() / std::sqrt(direct1.y()*direct1.y() + direct1.z()*direct1.z());
// std::cout<<"!!!!!!!!!!! (R1_y, R1_z) = ("<<R1_y<<", "<<R1_z<<") "<<std::endl;
// the vector pointing from the center of circle to the particle at layer 3 in Y-Z plane
double R2_z = charge * direct2.y() / std::sqrt(direct2.y()*direct2.y() + direct2.z()*direct2.z());
- double R2_y = -charge * direct2.z() / std::sqrt(direct2.y()*direct2.y() + direct2.z()*direct2.z());
+ // double R2_y = -charge * direct2.z() / std::sqrt(direct2.y()*direct2.y() + direct2.z()*direct2.z());
// std::cout<<"!!!!!!!!!!! (R2_y, R2_z) = ("<<R2_y<<", "<<R2_z<<") "<<std::endl;
// the norm of radius
double R = (pos2_0.z() - pos1_2.z()) / (R2_z - R1_z);
@@ -549,7 +549,7 @@ namespace Tracker
double p_x = direct1.x() * p_z / direct1.z();
// total momentum at the layer 0
const Acts::Vector3 mom(p_x, p_y, p_z);
- double p = mom.norm();
+ // double p = mom.norm();
// std::cout<<"!!!!!!!!!!! InitTrack momentum on layer 0: ( "<<mom.x()*1000<<", "<<mom.y()*1000<<", "<<mom.z()*1000<<", "<<p*1000<<") "<<std::endl;
// std::cout<<"!!!!!!!!!!! truth momentum: ( "<<truthmom.px()<<", "<<truthmom.py()<<", "<<truthmom.pz()<<", "<<truthmom.m()<<" ) "<<std::endl;
diff --git a/Tracking/Acts/FaserActsKalmanFilter/src/ActsTrackSeedTool.cxx b/Tracking/Acts/FaserActsKalmanFilter/src/ActsTrackSeedTool.cxx
index 4d90b6c7c619ec160bee114123066c7c25aa30a3..013e242db7572fc4a92875cd8a6188ed45bc5171 100644
--- a/Tracking/Acts/FaserActsKalmanFilter/src/ActsTrackSeedTool.cxx
+++ b/Tracking/Acts/FaserActsKalmanFilter/src/ActsTrackSeedTool.cxx
@@ -121,7 +121,7 @@ StatusCode ActsTrackSeedTool::finalize() {
Acts::CurvilinearTrackParameters ActsTrackSeedTool::get_params(
const Acts::GeometryContext& gctx, const Amg::Vector3D& pos1,
const Amg::Vector3D& pos2, const Amg::Vector3D& pos3,
- const Acts::BoundSymMatrix& cov, double origin) {
+ const Acts::BoundSymMatrix& cov, double /*origin*/) {
const auto surface = Acts::Surface::makeShared<Acts::PlaneSurface>(
Acts::Vector3 {0, 0, pos1.z()}, Acts::Vector3{0, 0, -1});
boost::container::small_vector<const Amg::Vector3D*, 3> spacepoints {};
diff --git a/Tracking/Acts/FaserActsKalmanFilter/src/CKF2.cxx b/Tracking/Acts/FaserActsKalmanFilter/src/CKF2.cxx
index 355e4a930024de1239d222e24fddf1f7560b6feb..68aceccd626edab5d1e0316a1364055cb061d160 100644
--- a/Tracking/Acts/FaserActsKalmanFilter/src/CKF2.cxx
+++ b/Tracking/Acts/FaserActsKalmanFilter/src/CKF2.cxx
@@ -277,7 +277,7 @@ StatusCode CKF2::execute() {
ATH_MSG_DEBUG(" position: " << params.position(geoctx).transpose());
ATH_MSG_DEBUG(" momentum: " << params.momentum().transpose());
ATH_MSG_DEBUG(" charge: " << params.charge());
- double charge = params.charge();
+ // double charge = params.charge();
std::unique_ptr<Trk::Track> track = makeTrack(geoctx, traj);
if (track) {
// outputTracks->push_back(std::move(track));
diff --git a/Tracking/Acts/FaserActsKalmanFilter/src/KalmanFitterTool.cxx b/Tracking/Acts/FaserActsKalmanFilter/src/KalmanFitterTool.cxx
index 686047ae7232deb09ca207f6599666f0bd022aa3..7e97a82dfc1bc93e95714c9bf00fcdbc75d405c7 100644
--- a/Tracking/Acts/FaserActsKalmanFilter/src/KalmanFitterTool.cxx
+++ b/Tracking/Acts/FaserActsKalmanFilter/src/KalmanFitterTool.cxx
@@ -40,7 +40,7 @@ StatusCode KalmanFitterTool::finalize() {
std::unique_ptr<Trk::Track>
KalmanFitterTool::fit(const EventContext &ctx, const Trk::Track &inputTrack,
- std::vector<FaserActsRecMultiTrajectory> &trajectories,
+ std::vector<FaserActsRecMultiTrajectory> & /*trajectories*/,
const Acts::BoundVector& inputVector = Acts::BoundVector::Zero()) const {
std::unique_ptr<Trk::Track> newTrack = nullptr;
std::vector<FaserActsRecMultiTrajectory> myTrajectories;
diff --git a/Tracking/Acts/FaserActsKalmanFilter/src/RootTrajectorySummaryWriterTool.cxx b/Tracking/Acts/FaserActsKalmanFilter/src/RootTrajectorySummaryWriterTool.cxx
index bb916b9bfefeaf47c013b29122c12eb48f17abf7..cb19d4dd9dbdce58901a7f1a002a7f3e1a986c9e 100644
--- a/Tracking/Acts/FaserActsKalmanFilter/src/RootTrajectorySummaryWriterTool.cxx
+++ b/Tracking/Acts/FaserActsKalmanFilter/src/RootTrajectorySummaryWriterTool.cxx
@@ -248,7 +248,7 @@ StatusCode RootTrajectorySummaryWriterTool::write(
continue;
}
// Get the truth particle info at vertex
- const HepMC::GenVertex* vertex = particle->production_vertex();
+ // const HepMC::GenVertex* vertex = particle->production_vertex();
t_p = truthParameters->momentum().mag();
t_charge = truthParameters->charge();
t_time = truthParameters->time();
diff --git a/Tracking/Acts/FaserActsKalmanFilter/src/ThreeStationTrackSeedTool.cxx b/Tracking/Acts/FaserActsKalmanFilter/src/ThreeStationTrackSeedTool.cxx
index 8c6eb8c0328b0ca194cb06083cc3c019cdbc0fd7..020c19b9cf4dfcfc1b8a5641d5e6c3765733161d 100644
--- a/Tracking/Acts/FaserActsKalmanFilter/src/ThreeStationTrackSeedTool.cxx
+++ b/Tracking/Acts/FaserActsKalmanFilter/src/ThreeStationTrackSeedTool.cxx
@@ -63,7 +63,7 @@ StatusCode ThreeStationTrackSeedTool::run() {
std::map<int, std::vector<Tracklet>> station_tracklet_map;
for (const Trk::Track* track : *trackCollection) {
- auto momentum = track->trackParameters()->front()->momentum();
+ // auto momentum = track->trackParameters()->front()->momentum();
int station = -1;
Amg::Vector3D trackletPosition {0, 0, 0};
std::vector<const Tracker::FaserSCT_Cluster*> trackletClusters {};
diff --git a/Tracking/Acts/FaserActsKalmanFilter/src/TrackSeedWriterTool.cxx b/Tracking/Acts/FaserActsKalmanFilter/src/TrackSeedWriterTool.cxx
index 42c4d1b7969d00e67b1f73ee21ff08a043c15df6..820e53cb18a6190992f3003c3df7fcd5fc751de9 100644
--- a/Tracking/Acts/FaserActsKalmanFilter/src/TrackSeedWriterTool.cxx
+++ b/Tracking/Acts/FaserActsKalmanFilter/src/TrackSeedWriterTool.cxx
@@ -75,6 +75,9 @@ void TrackSeedWriterTool::writeout(
m_eTHETA.push_back(parameters[Acts::eBoundTheta]);
m_eQOP.push_back(parameters[Acts::eBoundQOverP]);
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
+
const auto& covariance = *initialParameters.covariance();
m_err_eLOC0.push_back(sqrt(covariance(Acts::eBoundLoc0, Acts::eBoundLoc0)));
m_err_eLOC1.push_back(sqrt(covariance(Acts::eBoundLoc1, Acts::eBoundLoc1)));
@@ -82,6 +85,8 @@ void TrackSeedWriterTool::writeout(
m_err_eTHETA.push_back(sqrt(covariance(Acts::eBoundTheta, Acts::eBoundTheta)));
m_err_eQOP.push_back(sqrt(covariance(Acts::eBoundQOverP, Acts::eBoundQOverP)));
+#pragma GCC diagnostic pop
+
const auto& position = initialParameters.position(gctx);
const auto& momentum = initialParameters.momentum();
m_x.push_back(position.x());