Issue with PR 228
The PR !228 (merged) was merged in order to allow users to access the new tools, but some comments need to be still addressed:
-
ProductionTools/RD53TempSensor.cc
has a large set of registers writes hard coded -
RD53Interface::getADCobservable
inHWInterface/RD53Interface.cc
uses a bool* as function variable - some includes are not necessary
-
ProductionTools/ITchipTestingInterface.h
and class name do not match -
ProductionTools/ITchipTestingInterface.cc
assumes one specific power supply - C-like arrays must be replaced with std::vector
- Tools assumes only 1 chip tested
- Results files are overwritten, suggest to use the standard way of creating files
- Canvas saved in png and pdf should be avoided
-
src/ITchipTesting.cc
should be concatenated toProductionTools/CMSITprodToolDAQ.cc