Skip to content

Flag -Werror=overloaded-virtual causing local compilation failure but passing on the pipeline

Setup:

  • cmsuptkhsetup2 PC in hybrids lab
  • fresh installation of Alma 9 from network boot (from 20/03/23)
uname -a
Linux cmsuptkhsetup2 5.14.0-162.18.1.el9_1.x86_64 #1 SMP PREEMPT_DYNAMIC Tue Feb 28 03:54:43 EST 2023 x86_64 x86_64 x86_64 GNU/Linux
  • cmsph2_tcusb commit 889b673e9d9582dab64cfeb60990800970ee47af
  • Ph2_ACF commit 6754a0224c181368ee736166a79ff1b34c083a93
  • gcc (GCC) 11.3.1 20220421 (Red Hat 11.3.1-2)

Issue:

Since the merge 374 the class Tool has a different argument type in the virtual function Start(). Changed from int runNumber to const StartInfo& theStartInfo. This function was overriden in the PSROHTester.h but the argument changes were not applied and therefore the local compilation with the flag -Werror=overloaded-virtual was failing.

However on the CI pipeline https://gitlab.cern.ch/cms_tk_ph2/Ph2_ACF/-/jobs/28253193 the error is not visible in logs and the job is not failing.