Perform voltage_trimming calibration with TBPX 1x2 modules
Bug Report
- Please make sure you have selected the correct template (bug report/feature request) from the Description drop-down menu above.
- You can switch to either "plain text editing" or "rich text editing" as you prefer at the bottom of this text box.
- Please fill out all fields below.
Summary
master branch voltage_trimming array shape mismatch issue while testing TBPX duals
Expected Result
Successfully perform voltage_trimming calibration for TBPX dual modules using 1x2 needle card
Actual Result
Using the master branch for the voltage trimming process results in the following error:
File "/var/software/dirigent/master/module_testing/calibrations/voltage_trimming.py", line 110, in voltage_trimming
meas_data[:, setting] = buff_data # add to data array
ValueError: could not broadcast input array from shape (4,) into shape (8,)
The error results from the fact that line 63 of voltage_trimming.py reads meas_data = np.empty((8,16)), which allocates 4 slots for the vddd/vdda values. I propose the "8" should be replaced with len(enabled_rocs)*2 instead.
Steps to Reproduce
- Use
masterbranch - Connect 1x2 needle card
- Perform necessary steps to configure dirigent, etc.
- run
dirigent voltage_trimming
Checklist
Please note: depending on the issue, log files may be found either in your working directory, or in the Results_dirigent/ folder
-
I have attached my dirigent.toml,instruments.json, andmodules.jsonfiles -
I have attached the Ph2 ACF XML file -
I have attached the dirigent.logandstatus.logfiles -
I have zipped and attached the Ph2 ACF logs/folder
Final steps
- Please assign this report to @mfranks below.
- Add the label "bug" in the Labels field below.
- Please ignore Epic, Milestone, Weight, Due date, and Iteration fields below.
Edited by Matthew Lewis Franks