Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
  • Sign in
  • C cmsgemos
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
    • Locked files
  • Issues 94
    • Issues 94
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Artifacts
    • Schedules
    • Test cases
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Package Registry
    • Container Registry
    • Terraform modules
    • Model experiments
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Admin message

GitLab Runners cleaning campaign ongoing (ETA 2nd October 2023). Check https://cern.ch/otg0078219 for further information.

  • cmsgemonline
  • gem-daq
  • cmsgemos
  • Issues
  • #148
Closed
Open
Issue created Jan 27, 2021 by Dylan Oliver Teague@dteagueDeveloper

GEMMonitor should be deleted

Summary

GEMMonitor was intended to allow applications in the gem suite to have general monitoring capabilities in their respective monitor tabs, but as the monitoring has become more consolidated, the need for a centralized monitoring class is not necessary. Furthermore, GEMMonitor, is simply a wrapper for a timer and Infospaces for variables to be held on to. Since the processing of monitorables is being moved to the javascript/html page itself, the infospaces are overkill and the timer can be added to a class on a as-needed basis.

For this reason, the GEMMonitor class is redundant can can probably be removed.

!39 (closed) And previous attempts at MRs have tried to refactor the GEMMonitor class to being just a centralized timer factor, but this is probably not needed, especially as the gemmonitor area has been refactored.

This issue makes even more sense as the general xdaq structure changes in the future (e.g. removing the monitorTab from the xdaq default page basically neuters all of the need for GEMMonitor)

There may be a use to this class, but at the very least, a heavy refactor should be due to this class

Edited Jan 27, 2021 by Dylan Oliver Teague
Assignee
Assign to
Time tracking