Do not modify the calibration type when updating the calibration page
Description
At the moment, the calibration type in the Calibration
application is modified as soon as the calibration type is changed. This is not practical for multiple reasons:
- If the calibration web interface is already opened, the interface will not necessarily behave as expected (need to go back and forth between scan types).
- Multiple users looking in the calibration interface in parallel will interfere with each other.
- Scripting the calibration actions is made more complicated than needed.
One should make independent the web interface updates and application of the settings.
Possible fixes
A possible easy fix is:
- The
setCalType
function should not set them_calType
variable, but merely return the new web interface fragment:- Ideally the function is renamed and moved to the
CalibrationWeb
class (separation of concerns). - The utility of
m_calType
can also be re-evaluated.
- Ideally the function is renamed and moved to the
- The
cal_type_select
variable is already sent to theapplyAction
function and can simply be retrieved from there.