Skip to content

Improve the calibration suite user experience

Laurent Petre requested to merge bugfix/calibration-defaults into main

Description

As the title says, this MR aims at improving the calibration suite user experience, mainly by setting better defaults in the S-bit rate scan; the GBT phase scan; and the calibration pulse scan.

Additionally, we implement a feature preventing the start of a run or a scan if the system was not (re-)configured. In case of misuse, the FSM goes to the Error state. While somewhat restrictive, the feature can be disabled and, if not, make sure that the scan is taken as it should. Even better user experience could be implemented once #170 will be fixed.

Related Issue

Fixes #241 (closed)

How Has This Been Tested?

Tested on the GE1/1 integration setup in b904. Everything working as intended.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
Edited by Laurent Petre

Merge request reports