AnalysisTimingATLASpix: implement timing_cut -> time_cut_abs/rel as in \!156

src/modules/AnalysisTimingATLASpix/AnalysisTimingATLASpix.cpp

@@ -23,7 +23,14 @@ AnalysisTimingATLASpix::AnalysisTimingATLASpix(Configuration config, std::shared
 
     using namespace ROOT::Math;
     m_detector = detector;
-    m_timingCut = m_config.get<double>("timing_cut", static_cast<double>(Units::convert(1000, "ns")));
+    if(config.count({"time_cut_rel", "time_cut_abs"}) > 1) {
+        throw InvalidCombinationError(
+            m_config, {"time_cut_rel", "time_cut_abs"}, "Absolute and relative time cuts are mutually exclusive.");
+    } else if(m_config.has("time_cut_abs")) {
+        m_timeCut = m_config.get<double>("time_cut_abs");
+    } else {
+        m_timeCut = m_config.get<double>("time_cut_rel", 3.0) * m_detector->getTimeResolution();
+    }
     m_chi2ndofCut = m_config.get<double>("chi2ndof_cut", 3.);
     m_timeCutFrameEdge = m_config.get<double>("time_cut_frameedge", static_cast<double>(Units::convert(20, "ns")));
 
@@ -73,13 +80,13 @@ void AnalysisTimingATLASpix::initialise() {
 
     std::string name = "hTrackCorrelationTime";
     hTrackCorrelationTime =
-        new TH1F(name.c_str(), name.c_str(), static_cast<int>(2. * m_timingCut), -1 * m_timingCut, m_timingCut);
+        new TH1F(name.c_str(), name.c_str(), static_cast<int>(2. * m_timeCut), -1 * m_timeCut, m_timeCut);
     hTrackCorrelationTime->GetXaxis()->SetTitle("Track time stamp - cluster time stamp [ns]");
     hTrackCorrelationTime->GetYaxis()->SetTitle("# events");
 
     name = "hTrackCorrelationTimeAssoc";
     hTrackCorrelationTimeAssoc =
-        new TH1F(name.c_str(), name.c_str(), static_cast<int>(2. * m_timingCut), -1 * m_timingCut, m_timingCut);
+        new TH1F(name.c_str(), name.c_str(), static_cast<int>(2. * m_timeCut), -1 * m_timeCut, m_timeCut);
     hTrackCorrelationTimeAssoc->GetXaxis()->SetTitle("track time stamp - cluster time stamp [ns]");
     hTrackCorrelationTimeAssoc->GetYaxis()->SetTitle("# events");
 
@@ -92,33 +99,33 @@ void AnalysisTimingATLASpix::initialise() {
     name = "hTrackCorrelationTime_rowCorr";
     std::string title = "hTrackCorrelationTime_rowCorr: row-by-row correction";
     hTrackCorrelationTime_rowCorr =
-        new TH1F(name.c_str(), title.c_str(), static_cast<int>(2. * m_timingCut), -1 * m_timingCut, m_timingCut);
+        new TH1F(name.c_str(), title.c_str(), static_cast<int>(2. * m_timeCut), -1 * m_timeCut, m_timeCut);
     hTrackCorrelationTime_rowCorr->GetXaxis()->SetTitle("track time stamp - cluster time stamp [ns]");
     hTrackCorrelationTime_rowCorr->GetYaxis()->SetTitle("# events");
 
     name = "hTrackCorrelationTime_rowAndTimeWalkCorr";
     hTrackCorrelationTime_rowAndTimeWalkCorr =
-        new TH1F(name.c_str(), name.c_str(), static_cast<int>(2. * m_timingCut), -1 * m_timingCut, m_timingCut);
+        new TH1F(name.c_str(), name.c_str(), static_cast<int>(2. * m_timeCut), -1 * m_timeCut, m_timeCut);
     hTrackCorrelationTime_rowAndTimeWalkCorr->GetXaxis()->SetTitle("track time stamp - cluster time stamp [ns]");
     hTrackCorrelationTime_rowAndTimeWalkCorr->GetYaxis()->SetTitle("# events");
 
     name = "hTrackCorrelationTime_rowAndTimeWalkCorr_l25";
     hTrackCorrelationTime_rowAndTimeWalkCorr_l25 =
-        new TH1F(name.c_str(), name.c_str(), static_cast<int>(2. * m_timingCut), -1 * m_timingCut, m_timingCut);
+        new TH1F(name.c_str(), name.c_str(), static_cast<int>(2. * m_timeCut), -1 * m_timeCut, m_timeCut);
     hTrackCorrelationTime_rowAndTimeWalkCorr_l25->GetXaxis()->SetTitle(
         "track time stamp - cluster time stamp [ns] (if seed tot < 25lsb)");
     hTrackCorrelationTime_rowAndTimeWalkCorr_l25->GetYaxis()->SetTitle("# events");
 
     name = "hTrackCorrelationTime_rowAndTimeWalkCorr_l40";
     hTrackCorrelationTime_rowAndTimeWalkCorr_l40 =
-        new TH1F(name.c_str(), name.c_str(), static_cast<int>(2. * m_timingCut), -1 * m_timingCut, m_timingCut);
+        new TH1F(name.c_str(), name.c_str(), static_cast<int>(2. * m_timeCut), -1 * m_timeCut, m_timeCut);
     hTrackCorrelationTime_rowAndTimeWalkCorr_l40->GetXaxis()->SetTitle(
         "track time stamp - cluster time stamp [ns] (if seed tot < 40lsb)");
     hTrackCorrelationTime_rowAndTimeWalkCorr_l40->GetYaxis()->SetTitle("# events");
 
     name = "hTrackCorrelationTime_rowAndTimeWalkCorr_g40";
     hTrackCorrelationTime_rowAndTimeWalkCorr_g40 =
-        new TH1F(name.c_str(), name.c_str(), static_cast<int>(2. * m_timingCut), -1 * m_timingCut, m_timingCut);
+        new TH1F(name.c_str(), name.c_str(), static_cast<int>(2. * m_timeCut), -1 * m_timeCut, m_timeCut);
     hTrackCorrelationTime_rowAndTimeWalkCorr_g40->GetXaxis()->SetTitle(
         "track time stamp - cluster time stamp [ns] (if seed tot > 40lsb)");
     hTrackCorrelationTime_rowAndTimeWalkCorr_g40->GetYaxis()->SetTitle("# events");

src/modules/AnalysisTimingATLASpix/AnalysisTimingATLASpix.h

@@ -100,7 +100,7 @@ namespace corryvreckan {
 
         // Member Variables:
         std::string m_DUT;
-        double m_timingCut;
+        double m_timeCut;
         double m_chi2ndofCut;
         double m_timeCutFrameEdge;
         double m_clusterChargeCut;

src/modules/AnalysisTimingATLASpix/README.md

@@ -16,7 +16,8 @@ The calculation of the timewalk correction is based on a row-corrected histogram
 After this both corrections can be applied on top of each other.
 
 ### Parameters
-* `timing_cut`: Timing cut for associating a track with an ATLASpix cluster. Defaults to `1us`.
+* `time_cut_rel`: Number of standard deviations the `time_resolution` of the detector plane will be multiplied by. This value then defines the range of the track time correlation histograms and should be set according to the value chosen for the `[DUTAssociation]`. By default, a relative time cut is applied. Absolute and relative time cuts are mutually exclusive. Defaults to `3.0`.
+* `time_cut_abs`: Specifies an absolute value for the range of the track time correlation histograms and should be set according to the value chosen for the `[DUTAssociation]`. Absolute and relative time cuts are mutually exclusive. No default value.
 * `chi2ndof_cut`: Acceptance criterion for telescope tracks, defaults to a value of `3`.
 * `time_cut_frameedge`: Parameter to discard telescope tracks at the frame edges (start and end of the current frame). Defaults to `20ns`.
 * `cluster_charge_cut`: Parameter to discard clusters with a charge larger than the cut. No default, not used if not set.