Corryvreckan issueshttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues2024-01-31T07:04:20+01:00https://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/93Alignment4D2024-01-31T07:04:20+01:00Jens KroegerAlignment4DAt the BTTB8, the question came up whether we also support a 4D alignment, i.e. finding the correct time_shift to move the time residuals to zero.
This is currently not implemented. I'm just opening the ticket as a reminder/place for di...At the BTTB8, the question came up whether we also support a 4D alignment, i.e. finding the correct time_shift to move the time residuals to zero.
This is currently not implemented. I'm just opening the ticket as a reminder/place for discussion.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/175Provide Access to Track State Uncertainty2023-11-23T11:09:08+01:00Simon SpannagelProvide Access to Track State UncertaintyRight now it is only possible to access `Track::getState(std::string detector)` to get the intersection with the respective detector plane. It would however be great to also have access to the extra- or interpolation uncertainty on this ...Right now it is only possible to access `Track::getState(std::string detector)` to get the intersection with the respective detector plane. It would however be great to also have access to the extra- or interpolation uncertainty on this position.
This is of course also linked to !524 to provide correct uncertainties on global coordinates.Lennart HuthLennart Huthhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/5Implement Runlists2021-10-12T09:57:51+02:00Morag WilliamsImplement RunlistsI have many runs where the telescope is exactly the same, but the DUT has been rotated around the y axis. Currently I have to do the telescope alignment again, or have to have a separate telescope alignment file for each run (100s of fil...I have many runs where the telescope is exactly the same, but the DUT has been rotated around the y axis. Currently I have to do the telescope alignment again, or have to have a separate telescope alignment file for each run (100s of files).
Perhaps having an option to input these separately would fix the problem? I'm open to other options.Morag WilliamsMorag Williamshttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/120Possibility to analyse/combine multiple runs with same settings2020-08-04T13:39:57+02:00Jens KroegerPossibility to analyse/combine multiple runs with same settingsWould you think it's possible to add the feature to read in multiple runs directly in one analysis, e.g. to combine 2 or more runs for the alignment?
It could be something like:
```
[EventLoaderXYZ]
file_name = [path/to/file1, path/to/f...Would you think it's possible to add the feature to read in multiple runs directly in one analysis, e.g. to combine 2 or more runs for the alignment?
It could be something like:
```
[EventLoaderXYZ]
file_name = [path/to/file1, path/to/file2]
```
So when finishing with the first file, the 2nd file is read in with `time_offset = time@end-of-run` of the first file.
Any opinion?https://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/10Add GBL algorithm2020-01-17T18:55:59+01:00Simon SpannagelAdd GBL algorithmImplement a GBL track-refit algorithm for Corry. Mostly in view of potential test beams at PS next year and at DESY during LS2.
Requires track candidates as input, either take full `BasicTracking` tracks and simply do the re-fit, or spl...Implement a GBL track-refit algorithm for Corry. Mostly in view of potential test beams at PS next year and at DESY during LS2.
Requires track candidates as input, either take full `BasicTracking` tracks and simply do the re-fit, or split track finding and fitting in BasicTracking and then only use the track finder (probably overkill).
Also opens door to implementing alignment with GBL, where we simply need to write out the GBL tracks to binary and run `pede` on them.Simon SpannagelSimon Spannagelhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/57jobsub: MR !100 didn't address using jobsub for "local" job submission2019-10-11T12:55:18+02:00Jens Kroegerjobsub: MR !100 didn't address using jobsub for "local" job submissionMR !100 added the functionality to analyse one single run multiple runs with different parameters.
What it didn't address was making sure that this also works when not submitting jobs using HTCondor but running it locally. It will proba...MR !100 added the functionality to analyse one single run multiple runs with different parameters.
What it didn't address was making sure that this also works when not submitting jobs using HTCondor but running it locally. It will probably not work but hasn't been used yet...
__Priority:__ low to mediumhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/55FIXME: Sorting of data types in [EventLoaderEUDAQ2], follow-up of !982019-09-12T15:05:14+02:00Jens KroegerFIXME: Sorting of data types in [EventLoaderEUDAQ2], follow-up of !98__Jens:__
```cpp
// FIXME get TLU events with trigger IDs before Ni - sort by name, reversed
sort(events_.begin(), events_.end(), [](const eudaq::EventSPC& a, const eudaq::EventSPC& b) -> bool {
return a->GetDescription() > b->GetDescr...__Jens:__
```cpp
// FIXME get TLU events with trigger IDs before Ni - sort by name, reversed
sort(events_.begin(), events_.end(), [](const eudaq::EventSPC& a, const eudaq::EventSPC& b) -> bool {
return a->GetDescription() > b->GetDescription();
});
```
If I understand this code block correctly, it sorts the (sub-)events by name in reverse alphabetical order (z->a), right?
So it's fine for now because `TluRawDataEvent` ends up before `NiRawDataEvent`. But once we introduce another detector with data like `ZdetRawDataEvent` it'll fail.
So what if we introduced another parameter in the config file like
```toml
data_type_order = ["TluRawDataEvent","NiRawDataEvent"]
```
and then we sort according to the position of the names in the list?
__Simon:__
If you implement this, please take care of all corner cases (some data type not specified, the data type specified does not exist) and also keep the performance of the algorithm in mind. Especially string comparisons are very heavy. Make sure to document the behavior of this properly.Jens KroegerJens Kroegerhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/60EventloaderEUDAQ2 can only handle triggerIDsync data2019-09-12T15:05:14+02:00Lennart HuthEventloaderEUDAQ2 can only handle triggerIDsync dataThe current implementation of the converter can only handle TLU/NI events sorted by triggerID. For eventID synched data, the first plane read in is always skipped.The current implementation of the converter can only handle TLU/NI events sorted by triggerID. For eventID synched data, the first plane read in is always skipped.Jens KroegerJens Kroegerhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/56jobsub: not possible to process same run with multiple configurations2019-05-08T13:00:32+02:00Jens Kroegerjobsub: not possible to process same run with multiple configurationsThe htcondor jobsub works well for multiple run (different run numbers).
What I would like to do as well is process the same run multiple times with different analysis parameters, e.g.
```
RunNumber, TimingCut
29674, 100us
29674, 200us
...The htcondor jobsub works well for multiple run (different run numbers).
What I would like to do as well is process the same run multiple times with different analysis parameters, e.g.
```
RunNumber, TimingCut
29674, 100us
29674, 200us
29674, 300us
```
However, the `jobsub.py` script only parses the csv table until the first match of the run number, and doesn't catch the second and third line.
It would also be nice if all runs specified in the csv table would be submitted if not specifying any run number as an input parameter to jobsub.py:
```bash
jobsub.py [runs]
```
For this, it would also be necessary to change the name the generated config file (merged from config template and csv table). Currently, this is `<run_number>-<name_of_config_file>.conf`.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/22Allow for multiple DUTs2018-11-08T16:44:30+01:00Simon SpannagelAllow for multiple DUTs