Corryvreckan issueshttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues2019-09-06T10:18:30+02:00https://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/71Adapt names of multiplicity histograms in EventLoader type modules2019-09-06T10:18:30+02:00Morag WilliamsAdapt names of multiplicity histograms in EventLoader type modulesPlots of the number of pixels per `Corryvreckan` event are named in most event loader type modules as `pixelsPerFrame`, but the title of the histogram is "Pixel multiplicity per Corry frame". This could be unified.
My idea is to title t...Plots of the number of pixels per `Corryvreckan` event are named in most event loader type modules as `pixelsPerFrame`, but the title of the histogram is "Pixel multiplicity per Corry frame". This could be unified.
My idea is to title these histograms as "Pixel multiplicity per Corry event", and name these histograms in the code and ROOT file as `pixelMultiplicity`.Morag WilliamsMorag Williamshttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/58EventLoaderEUDAQ2: make string comparison for detector_name == plane_name cas...2019-05-09T12:03:03+02:00Jens KroegerEventLoaderEUDAQ2: make string comparison for detector_name == plane_name case-insensitiveIn the `[EventLoaderEUDAQ2]` we're comparing the name the current detector to each plane name.
This requires the detectors to be named according to the following convention: `<sensor_type>_<int>`.
```cpp
// Concatenate plane nam...In the `[EventLoaderEUDAQ2]` we're comparing the name the current detector to each plane name.
This requires the detectors to be named according to the following convention: `<sensor_type>_<int>`.
```cpp
// Concatenate plane name according to naming convention: sensor_type + "_" + int
auto plane_name = plane.Sensor() + "_" + std::to_string(i_plane);
if(m_detector->name() != plane_name) {
LOG(DEBUG) << "Wrong plane: " << m_detector->name() << "!=" << plane_name << ". Continue.";
continue;
}
```
It can easily happen that you're mixing up the spelling of something like `ATLASpix` and `ATLASPix`, only one of which works and the other fails.
I think this should be avoided by making the string comparison here case-insensitive.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/42Clipboard/Objects: Don't use Vector of Pointer2020-05-07T16:11:21+02:00Simon SpannagelClipboard/Objects: Don't use Vector of PointerI would like to rework the data objects and the clipboard to not use `std::vector<Object*>*` but rather just `std::shared_ptr<std::vector<Object>>` which is what is needed for not moving/copying memory around.
This is a bit involved sin...I would like to rework the data objects and the clipboard to not use `std::vector<Object*>*` but rather just `std::shared_ptr<std::vector<Object>>` which is what is needed for not moving/copying memory around.
This is a bit involved since objects store references to each other, which should be pointers, obviously. Postponing this work.