Corryvreckan issueshttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues2019-05-15T16:20:55+02:00https://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/59Fatal internal error in AnalysisEfficiency (merged into master branch)2019-05-15T16:20:55+02:00Jens KroegerFatal internal error in AnalysisEfficiency (merged into master branch)In `AnalysisEfficiency`:
```cpp
static_cast<int>(ceil(pitch_x / m_inpixelBinSize));
```
leads to Fatal internal error `std::bad_alloc` after commit f08fd1ffff2a0ce1a61149fbdeda687466fc7bb5
__EDIT:__
The problem was that `pitch_x` is ...In `AnalysisEfficiency`:
```cpp
static_cast<int>(ceil(pitch_x / m_inpixelBinSize));
```
leads to Fatal internal error `std::bad_alloc` after commit f08fd1ffff2a0ce1a61149fbdeda687466fc7bb5
__EDIT:__
The problem was that `pitch_x` is converted to `um` previously, but `m_inpixelBinSize` was in default `nm`. Consequently, the binning was too high by a factor of 1000.
This is too much for ROOT.
Now we throw an error if more than 10k bins are requested in either x or y, which is more than enough for all practical reasons. E.g. for the ATLASpix with `130um` by `40um`, this allows to go down to a binning of `0.013um = 13nm` which is way below all expected in-pixel effects that can be seen with a track pointing resolution in the order of `1um`.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/72To Do before Release 1.02019-11-18T11:05:10+01:00Simon SpannagelTo Do before Release 1.0This is a summary ticket for open tasks to be implemented before we release version 1.0. The list is not necessarily exhaustive and should be extended if necessary.
* [x] Update FileReader/Writer via !155
* [x] Support all sensible com...This is a summary ticket for open tasks to be implemented before we release version 1.0. The list is not necessarily exhaustive and should be extended if necessary.
* [x] Update FileReader/Writer via !155
* [x] Support all sensible combinations of detectors in EUDAQ2 via !145
* [x] Update and finalize the manual via !164
* [x] Add test cases for EUDAQ2 data with CLICpix2, Timepix3 and ATLASpix via !112
* [x] Clean-up of detector class: coordinate transformations (!114), resolution (!156)
* [x] Improve job submission script via #57
* [x] Fix CMake issues with EUDAQ1/EUDAQ2 linking: #521.0https://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/40Add Test Cases and a CI Testing Stage2018-12-12T10:07:22+01:00Simon SpannagelAdd Test Cases and a CI Testing StageFor every detector/DUT supported, we should add one test case with abbreviated data files, placed on the newly created EOS project space to be found at `/eos/project/c/corryvreckan/`. A script should be able to download these files and e...For every detector/DUT supported, we should add one test case with abbreviated data files, placed on the newly created EOS project space to be found at `/eos/project/c/corryvreckan/`. A script should be able to download these files and execute the framework with the corresponding configuration files.
The output checked should e.g. be the number of tracks found.
This way we can monitor that new additions or changes do not break compatibility with our existing setups and data sets.Simon SpannagelSimon Spannagelhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/issues/37Provide CMVFS Installation2018-11-13T15:25:36+01:00Morag WilliamsProvide CMVFS InstallationProvide central CMVFS installation for SLC6 and CC7Provide central CMVFS installation for SLC6 and CC7