Clang and EventLoaderEUDAQ2: moving a temporary object prevents copy elision
L503 in src/modules/EventLoaderEUDAQ2/EventLoaderEUDAQ2.cpp
does not compile on macOS 12.4
, AppleClang 13.1.6.13160021
.
Full output:
Consolidate compiler generated dependencies of target CorryvreckanModuleEventLoaderEUDAQ2
[ 61%] Building CXX object src/modules/EventLoaderEUDAQ2/CMakeFiles/CorryvreckanModuleEventLoaderEUDAQ2.dir/EventLoaderEUDAQ2.cpp.o
/Users/msuljic/cernbox/its3/sw/corryvreckan/src/modules/EventLoaderEUDAQ2/EventLoaderEUDAQ2.cpp:503:45: error: moving a temporary object prevents copy elision [-Werror,-Wpessimizing-move]
Waveform::waveform_t{std::move(plane.GetWaveform(i)), plane.GetWaveformX0(i), plane.GetWaveformDX(i)})
^
/Users/msuljic/cernbox/its3/sw/corryvreckan/src/modules/EventLoaderEUDAQ2/EventLoaderEUDAQ2.cpp:503:45: note: remove std::move call here
Waveform::waveform_t{std::move(plane.GetWaveform(i)), plane.GetWaveformX0(i), plane.GetWaveformDX(i)})
^~~~~~~~~~ ~
1 error generated.
make[2]: *** [src/modules/EventLoaderEUDAQ2/CMakeFiles/CorryvreckanModuleEventLoaderEUDAQ2.dir/EventLoaderEUDAQ2.cpp.o] Error 1
make[1]: *** [src/modules/EventLoaderEUDAQ2/CMakeFiles/CorryvreckanModuleEventLoaderEUDAQ2.dir/all] Error 2
Not caught by CI as it doesn't check this module.