Corryvreckan merge requestshttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests2018-12-18T16:54:10+01:00https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/77ConfigManager: delay parsing of detectors_file until needed2018-12-18T16:54:10+01:00Simon SpannagelConfigManager: delay parsing of detectors_file until neededThis fixes #45This fixes #45Morag WilliamsMorag Williamshttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/94Fixing pixel tolerance cut in hasIntercept function of detector class2019-03-14T11:10:03+01:00Morag WilliamsFixing pixel tolerance cut in hasIntercept function of detector classThe function "hasIntercept()" in Detector.cpp applied a pixel tolerance cut, which is an input parameter to the function. However, this cut was applied asymmetrically such that an extra row and column were excluded on one side compared t...The function "hasIntercept()" in Detector.cpp applied a pixel tolerance cut, which is an input parameter to the function. However, this cut was applied asymmetrically such that an extra row and column were excluded on one side compared to the other.
I have changed the cut formula so it is applied equally and applies the input value (rather than the input value minus half a pixel pitch as before). To account for this I adapted the inputted pixel tolerance values used in hasIntercept() in AnalysisDUT and AnalysisEfficiency, which are the only places I found that use this function. Note the getIntercept() function was not affected.
I also added an extra plot in AnalysisDUT showing the local position of associated tracks.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/107AnalysisEfficiency: bug fix2019-05-14T15:01:33+02:00Jens KroegerAnalysisEfficiency: bug fix`AnalysisEfficiency`: moved calculation of binning in front of TProfile booking + error will be thrown if bin number is too fine for ROOT. Also correct conversion to um.
This fixes #59.`AnalysisEfficiency`: moved calculation of binning in front of TProfile booking + error will be thrown if bin number is too fine for ROOT. Also correct conversion to um.
This fixes #59.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/169Bugfix in EUDAQ event loader - compilation broken2019-09-16T14:36:11+02:00Paul Jean SchutzeBugfix in EUDAQ event loader - compilation brokenAdded a missing semicolon.Added a missing semicolon.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/184Fix typo at printing cluster coordinates: was x/y/x instead of x/y/z2019-10-17T09:57:33+02:00Paul Jean SchutzeFix typo at printing cluster coordinates: was x/y/x instead of x/y/zSee titleSee titlehttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/252EventLoaderCLICpix2: fix calculation to set timestamp half way between the sh...2020-02-12T11:08:53+01:00Morag WilliamsEventLoaderCLICpix2: fix calculation to set timestamp half way between the shutter open and closeCalculation of the default pixel timestamp in `EventLoaderCLICpix2` was incorrect. It was:
`double timestamp = (shutterStartTime - shutterStopTime) / 2;`
and now it is in the middle of the frame as wanted:
`double timestamp = shutterS...Calculation of the default pixel timestamp in `EventLoaderCLICpix2` was incorrect. It was:
`double timestamp = (shutterStartTime - shutterStopTime) / 2;`
and now it is in the middle of the frame as wanted:
`double timestamp = shutterStartTime + (shutterStopTime - shutterStartTime) / 2;`https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/269Change track finding algorithm of Tracking4D2020-04-08T19:09:20+02:00Paul Jean SchutzeChange track finding algorithm of Tracking4DThe track finding in the `Tracking4D` module is currently malfunctioning:
`Cluster`s are added to the track candidate (`StraightLineTrack`) one by one. For the second cluster, currently the following condition has to be true: The hit ...The track finding in the `Tracking4D` module is currently malfunctioning:
`Cluster`s are added to the track candidate (`StraightLineTrack`) one by one. For the second cluster, currently the following condition has to be true: The hit in a detector has to be at the same global position in x and y as the reference (first) cluster (within the range of the spatial cuts).
With this, we only allow for tracks that have no slopes, or to precise at maximum have an angle w.r.t. the global coordinate system of
```
slope_max = spatial_cut/(ref_plane.z()-new_plane.z())
```
per transverse direction.
New method: Loop over each combination of clusters in two reference planes, then proceed as before: check for clusters close to the track.
This improves angular acceptance and overall probability of track finding, since the previous implementation discarded clusters for which the first track attempt did not lead to a track.
Example: Tracking4D in 6 planes of Mimosa26 detectors, process 50 kEvents.
* `master`: 0.056 tracks/ev
* `bugfixTracking`: 0.686 tracks/evhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/285Fix memory leak in track base class2020-04-16T09:00:02+02:00Paul Jean SchutzeFix memory leak in track base classIn the track base class constructor `Track(Track& track)`, clusters are created and never deleted.
I am not sure whether using the clusters of the initial `track` is the correct way to do it, or whether the clusters should be created h...In the track base class constructor `Track(Track& track)`, clusters are created and never deleted.
I am not sure whether using the clusters of the initial `track` is the correct way to do it, or whether the clusters should be created here and deleted in the constructor.Simon SpannagelSimon Spannagelhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/296Fix and add clustering plots2020-04-24T12:23:54+02:00Paul Jean SchutzeFix and add clustering plotsFor `ClusteringSpatial`:
* Fix plot for local cluster map (showed local position instead of cluster coordinates before)
* Adjusted graph to show pixels from -0.5 to npix-0.5 instead of -npix/2 to npix/2
For `Clustering4D`:
* Add plot...For `ClusteringSpatial`:
* Fix plot for local cluster map (showed local position instead of cluster coordinates before)
* Adjusted graph to show pixels from -0.5 to npix-0.5 instead of -npix/2 to npix/2
For `Clustering4D`:
* Add plot for local cluster map
* Adjust graph for global cluster position to what is done for `ClusteringSpatial`https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/383Fixup: update devtoolset in docker file2020-11-12T13:35:02+01:00Simon SpannagelFixup: update devtoolset in docker filehttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/397Fix path in setup_lxplus, this fixes #139 #1402021-02-10T16:02:48+01:00Simon SpannagelFix path in setup_lxplus, this fixes #139 #140https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/400Catch events with negative duration in EventLoaderEUDAQ22021-02-26T09:09:33+01:00Paul Jean SchutzeCatch events with negative duration in EventLoaderEUDAQ2This should fix an issue where events with negative duration (frame end before frame start) are not correctly addressed.
Done by adding only events to the clipboard that have the event position `DURING` and by resetting the event if the...This should fix an issue where events with negative duration (frame end before frame start) are not correctly addressed.
Done by adding only events to the clipboard that have the event position `DURING` and by resetting the event if the marker `UNKNOWN` is found.
Background: Without this fix, an event with negative duration leads to the event being added to the current event. For the consecutive runs, the bad event keeps being read and the run loop is stuck on this particular event.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/413CI: unbreak mac packaging2021-04-20T10:01:53+02:00Simon SpannagelCI: unbreak mac packaginghttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/417Finish porting jobsub to python32021-04-22T08:53:39+02:00Jens KroegerFinish porting jobsub to python3Python3 distinguished between byte strings (`byte`) and strings (`str`).
MR !406 works but only in batch mode (`--batch`).
This MR completes the porting to python3 also for the non-batch mode.
Fixes #144.Python3 distinguished between byte strings (`byte`) and strings (`str`).
MR !406 works but only in batch mode (`--batch`).
This MR completes the porting to python3 also for the non-batch mode.
Fixes #144.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/477Multiplet: Fix problematic default value for isolation cut2021-11-17T11:35:08+01:00Paul Jean SchutzeMultiplet: Fix problematic default value for isolation cutThe default `isolation_cut` was set to an uninitialized variable, thus tracking mostly failed.The default `isolation_cut` was set to an uninitialized variable, thus tracking mostly failed.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/484Fix packing for CC82021-12-03T18:07:13+01:00Simon SpannagelFix packing for CC8https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/493Add TDirectory header2022-01-24T10:01:55+01:00Simon SpannagelAdd TDirectory headerhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/503Default to LLVM on LXPLUS2022-02-02T12:49:14+01:00Simon SpannagelDefault to LLVM on LXPLUS...to make `clang-format-12` and `clang-tidy-12` available by default. They are part of the LLVM compiler collection....to make `clang-format-12` and `clang-tidy-12` available by default. They are part of the LLVM compiler collection.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/514EventLoaderEUDAQ1: fix compilation with new Config Class2022-03-30T14:41:08+02:00Simon SpannagelEventLoaderEUDAQ1: fix compilation with new Config Classhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/536Clipboard: remove keys if storage is empty2022-07-04T10:25:54+02:00Simon SpannagelClipboard: remove keys if storage is emptyUp till now the key was not cleared if all data was removed from the keyboard for a given type and key. Now we drop the key so they can be re-added.
In addition there is now `appendData` which allows to add data to existing collections....Up till now the key was not cleared if all data was removed from the keyboard for a given type and key. Now we drop the key so they can be re-added.
In addition there is now `appendData` which allows to add data to existing collections. Use with care.
@lhuth please testSimon SpannagelSimon Spannagel