Corryvreckan merge requestshttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests2018-12-17T17:33:24+01:00https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/76Allow Overwriting of Detector Parameters from Commandline2018-12-17T17:33:24+01:00Simon SpannagelAllow Overwriting of Detector Parameters from CommandlineThis MR updates the ConfigManager and ModuleManager and introduces a few structural changes on how configurations are handled. The main benefit from this is, that we can overwrite detector parameters such as rotation directly from the co...This MR updates the ConfigManager and ModuleManager and introduces a few structural changes on how configurations are handled. The main benefit from this is, that we can overwrite detector parameters such as rotation directly from the command line.
This means, for an angular scan, you don't have to produce 80 detector files, but a simple bash script is fine:
```bash
for angle in {0..79}; do
corry -c configfile.conf -g mydut.orientation=0deg,${angle},0deg -o detectors_file_upd="mygeometry_${angle}deg.conf";
done
```
and it will automatically update the detector configuration accordingly. This works for all configuration keys, i.e. allows to on-the-fly assign the DUT role to different detectors or to change the pixel pitch (probably less useful...)https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/75fixing 2 memory leaks2018-12-13T11:49:36+01:00Jens Kroegerfixing 2 memory leaks* Deleting pointer when not needed anymore.
* Checked by rerunning valgrind.* Deleting pointer when not needed anymore.
* Checked by rerunning valgrind.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/74script to setup environment for lxplus2018-12-13T10:42:37+01:00Jens Kroegerscript to setup environment for lxplus* new /etc/README.md
* new /etc/setup_lxplus.sh
inspired by Allpix-Squared* new /etc/README.md
* new /etc/setup_lxplus.sh
inspired by Allpix-Squaredhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/73updated manual wrt: data-driver functionality tests2018-12-12T12:10:09+01:00Jens Kroegerupdated manual wrt: data-driver functionality testsExplained usage of SHA256Explained usage of SHA256https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/72Add SIGTERM interrupt handler to gracefully exit (allows to store data if job...2018-12-12T11:20:57+01:00Jens KroegerAdd SIGTERM interrupt handler to gracefully exit (allows to store data if job is killed)See https://gitlab.cern.ch/allpix-squared/allpix-squared/merge_requests/186See https://gitlab.cern.ch/allpix-squared/allpix-squared/merge_requests/186https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/71Add Testing to CI2018-12-12T10:07:21+01:00Simon SpannagelAdd Testing to CIThis MR adds the functionality we have long discussed and fixes #40. It enables automatic testing of the framework using predefined data sets.
The functionality consists of:
* A CMake script which is capable of automatically picking ...This MR adds the functionality we have long discussed and fixes #40. It enables automatic testing of the framework using predefined data sets.
The functionality consists of:
* A CMake script which is capable of automatically picking up all test cases defined
* A download script which fetches the relevant data from our project EOS storage at `/eos/project/c/corryvreckan/www/data`
* A Corryvreckan configuration file for each test case in `testing/`
* A corresponding geometry file in `testing/geometries/`
Currently, I have added one test, running just the seven planes of our Timepix3 telescope and doing tracking, no DUT, no DUTModules. I have taken the original data files and stripped each of them down to 10MB. This way, about 200k tracks remain in the data, but the total package is only 50MB to download.
The configuration file for the test contains two special markers:
```toml
#DATASET timepix3tel_ebeam120
#PASS Ev: 18.8k Tr: 197.4k (10.5/ev) t = 3.76s
```
Here, `#DATASET` defines the data to be downloaded. Currently, the file has to be of `.tar.gz` format and registered with its SHA256 has in `download_data.py`. `#PASS` defines the regular expression to be searched for in the Corryvreckan console output in order for the test to pass. The latter works just as described in the Allpix Squared manual, Chapter 10.
After merging this, we should work on collecting ideas for more test cases - even if it's just a different analysis, a different geometry with alignment etc. The data sets can be reused without downloading them again, as the `download_data.py` script checks for their existence.
@dannheim @jekroege @williammhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/70CleanUp of TrackingSpatial2018-12-18T17:09:13+01:00Simon SpannagelCleanUp of TrackingSpatialThis MR cleans up TrackingSpatial a bit, mostly costemtics (removung unsed variables) but also fixes #20 via ca3b6b7ac80b468e70645db9faa3bbeaf3bc27d3This MR cleans up TrackingSpatial a bit, mostly costemtics (removung unsed variables) but also fixes #20 via ca3b6b7ac80b468e70645db9faa3bbeaf3bc27d3https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/69Unbreak MaskCreator2018-12-11T09:50:19+01:00Simon SpannagelUnbreak MaskCreatorFixed a few bugs in MaskCreator module, now
* the correct pixels are written to file (previously we had a off-by-one error due to ROOT histogram binning)
* the local density estimator works (didn't because we weren't recording the numbe...Fixed a few bugs in MaskCreator module, now
* the correct pixels are written to file (previously we had a off-by-one error due to ROOT histogram binning)
* the local density estimator works (didn't because we weren't recording the number of events to normalize to)https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/68Detector Class: Document header, simply functions2018-12-10T10:07:37+01:00Simon SpannagelDetector Class: Document header, simply functionsThis MR cleans up the `Detector` class a bit by adding Doxygen documentation to the header and combines a few functions that still existed individually for each coordinate.This MR cleans up the `Detector` class a bit by adding Doxygen documentation to the header and combines a few functions that still existed individually for each coordinate.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/67Cosmetics: improve printout for millions of events/tracks2018-12-07T14:46:53+01:00Simon SpannagelCosmetics: improve printout for millions of events/tracksNow it says:
```
|14:18:48.581| (STATUS) Ev: 124.0k Tr: 1.61M (13/ev) t = 24.8s
```Now it says:
```
|14:18:48.581| (STATUS) Ev: 124.0k Tr: 1.61M (13/ev) t = 24.8s
```https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/66fixed masking issue #392018-12-07T11:49:57+01:00Jens Kroegerfixed masking issue #39Here's the next merge request:
* Solved Pixel Masking Issue #39
* tested functionality using run 29674.Here's the next merge request:
* Solved Pixel Masking Issue #39
* tested functionality using run 29674.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/65fixed conversion local -> in-pixel2018-12-03T13:46:27+01:00Jens Kroegerfixed conversion local -> in-pixel* generic calculation for in-pixel projection valid for even and odd row/column numbers
* tested/validated with run 29656* generic calculation for in-pixel projection valid for even and odd row/column numbers
* tested/validated with run 29656https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/64Fixed fillings of timing histogrammes in AnalysisDUT2018-12-03T08:53:31+01:00Florian Michael PittersFixed fillings of timing histogrammes in AnalysisDUTTiming histogrammes were created but not filled.Timing histogrammes were created but not filled.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/63EventLoaderTimepix3: bugfix for missing plane data2018-11-17T11:44:27+01:00Dominik DannheimEventLoaderTimepix3: bugfix for missing plane dataIgnore power pulsing headers for all detectors, except the DUT.
Previously this was the other way around, so that data from telescope
planes was not read after a corrupt header
0x0. This affected many runs in the November 2018 test-beam ...Ignore power pulsing headers for all detectors, except the DUT.
Previously this was the other way around, so that data from telescope
planes was not read after a corrupt header
0x0. This affected many runs in the November 2018 test-beam data taking.
Note that the power-pulsing code is probably anyway outdated,
as Estel used a different branch.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/62Manual: Add Installation Chapter2018-11-13T16:39:43+01:00Simon SpannagelManual: Add Installation ChapterThis MR adds the chapter for installation to the user manual.
Please review and merge.This MR adds the chapter for installation to the user manual.
Please review and merge.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/61Extend CI2019-09-04T14:49:01+02:00Simon SpannagelExtend CIAdd linting target and deployment to EOS and CVMFS.Add linting target and deployment to EOS and CVMFS.Simon SpannagelSimon Spannagelhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/60ATLASPix: Support for DeadTime status code2018-11-13T10:32:19+01:00Tomas VanatATLASPix: Support for DeadTime status codehttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/59Move CLICpix2 Decoder into Corryvreckan sources2018-11-13T16:03:15+01:00Simon SpannagelMove CLICpix2 Decoder into Corryvreckan sourcesThis MR replicates the data decoder for CLICpix2 from Peary into Corryvreckan. This avoid the dependency to Peary and allows to more easily deploy Corryvreckan.
Since I had to adapt the decoder to match the strict compiler warning rules...This MR replicates the data decoder for CLICpix2 from Peary into Corryvreckan. This avoid the dependency to Peary and allows to more easily deploy Corryvreckan.
Since I had to adapt the decoder to match the strict compiler warning rules enables in this repository, its functionality should be tested with at least one TOT+CNT and one TOT+TOA mode run.
@williamm could you test this?Simon SpannagelSimon Spannagelhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/58Added BUSY warning for ATLASPix event loader, fixed issue when T0 was the fir...2018-11-12T15:01:03+01:00Tomas VanatAdded BUSY warning for ATLASPix event loader, fixed issue when T0 was the first event in data file;https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/57Added improvement of track timestamp to BasicTracking module2018-11-07T13:03:32+01:00Florian Michael PittersAdded improvement of track timestamp to BasicTracking moduleThe Basic Tracking module now takes the average of all track planes with a hit instead of the timestamp from the reference plane.
![reference_plane_only](/uploads/eafae6beaad2c8b179b6e51306a7b339/reference_plane_only.png)
![average_of_a...The Basic Tracking module now takes the average of all track planes with a hit instead of the timestamp from the reference plane.
![reference_plane_only](/uploads/eafae6beaad2c8b179b6e51306a7b339/reference_plane_only.png)
![average_of_all_planes](/uploads/f639a058a99c764885b5b03728b71a55/average_pf_all_planes.png)