Corryvreckan merge requestshttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests2019-05-08T13:00:32+02:00https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/100jobsub: process same run with multiple configurations2019-05-08T13:00:32+02:00Jens Kroegerjobsub: process same run with multiple configurationsI rewrote the python script such that it is now also possible to process the same run with various cuts.
This closes #56.
Before merging, I'll test it more thoroughly and update the README as well.I rewrote the python script such that it is now also possible to process the same run with various cuts.
This closes #56.
Before merging, I'll test it more thoroughly and update the README as well.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/99Changing Pixel object: renaming "tot" to "value"2019-05-15T16:56:35+02:00Jens KroegerChanging Pixel object: renaming "tot" to "value"After discussion with Simon:
So far, the `Pixel` object has a member called ToT which is not an appropriate name for a variable that is only the ToT for particular detectors. In other cases than the ATLASpix, the CLICpix2 or so, it migh...After discussion with Simon:
So far, the `Pixel` object has a member called ToT which is not an appropriate name for a variable that is only the ToT for particular detectors. In other cases than the ATLASpix, the CLICpix2 or so, it might be a value with a completely different meaning, e.g. a particular ADC.
Consequently, it should be renamed.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/98Updated EventLoaderEUDAQ22019-05-06T16:47:19+02:00Jens KroegerUpdated EventLoaderEUDAQ2This merge request contains the rewritten EventLoaderEUDAQ2.
What needs to be done before merging:
* [x] some basic histograms
* [x] allow only TLU+Mimosa --> fix how clipboard event is created
* [x] Documentation
* [x] Test case ...This merge request contains the rewritten EventLoaderEUDAQ2.
What needs to be done before merging:
* [x] some basic histograms
* [x] allow only TLU+Mimosa --> fix how clipboard event is created
* [x] Documentation
* [x] Test case with TLU+Tel+DUT in EUDAQ2Jens KroegerJens Kroegerhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/97AnalysisEfficiency and AnalysisDUT: adding additional plots2019-03-20T17:36:47+01:00Morag WilliamsAnalysisEfficiency and AnalysisDUT: adding additional plotsTo `AnalysisEfficiency` I have added two plots where the efficiency is filled at the position of the centre of the associated cluster, in global and local coordinates. The names of the plots have been adapted to reflect what position has...To `AnalysisEfficiency` I have added two plots where the efficiency is filled at the position of the centre of the associated cluster, in global and local coordinates. The names of the plots have been adapted to reflect what position has been filled into the histogram.
To `AnalysisDUT` I have added a plot of the normalised associated cluster size.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/96Swap column/row in Detector::getLocalPosition to be consistent2019-05-06T15:13:56+02:00Simon SpannagelSwap column/row in Detector::getLocalPosition to be consistentAre there more places where we do not use `column` properly as x coordinate?Are there more places where we do not use `column` properly as x coordinate?https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/95Metronome: allow to skip ahead at begin of run2019-03-18T17:08:29+01:00Simon SpannagelMetronome: allow to skip ahead at begin of runtitle says it all.title says it all.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/94Fixing pixel tolerance cut in hasIntercept function of detector class2019-03-14T11:10:03+01:00Morag WilliamsFixing pixel tolerance cut in hasIntercept function of detector classThe function "hasIntercept()" in Detector.cpp applied a pixel tolerance cut, which is an input parameter to the function. However, this cut was applied asymmetrically such that an extra row and column were excluded on one side compared t...The function "hasIntercept()" in Detector.cpp applied a pixel tolerance cut, which is an input parameter to the function. However, this cut was applied asymmetrically such that an extra row and column were excluded on one side compared to the other.
I have changed the cut formula so it is applied equally and applies the input value (rather than the input value minus half a pixel pitch as before). To account for this I adapted the inputted pixel tolerance values used in hasIntercept() in AnalysisDUT and AnalysisEfficiency, which are the only places I found that use this function. Note the getIntercept() function was not affected.
I also added an extra plot in AnalysisDUT showing the local position of associated tracks.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/93Fix unit conversion of module default values2019-03-04T15:06:07+01:00Jens KroegerFix unit conversion of module default valuesThis solves #50.
I corrected `Units::convert()` to `Units::get()` in the constructors of all of the following modules:
* [AnalysisCLICpix]
* [AnalysisDUT]
* [AnalysisEfficiency]
* [Clustering4D]
* [DUTAssociation]
* [EventLoaderATLASpi...This solves #50.
I corrected `Units::convert()` to `Units::get()` in the constructors of all of the following modules:
* [AnalysisCLICpix]
* [AnalysisDUT]
* [AnalysisEfficiency]
* [Clustering4D]
* [DUTAssociation]
* [EventLoaderATLASpix]
* [FileReader]
* [ImproveReferenceTimestamp]
* [Metronome]
* [Prealignment]
* [TestAlgorithm]
* [Tracking4D]
* [TrackingSpatial]https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/92Fixing add module2019-02-27T19:27:00+01:00Jens KroegerFixing add moduleThis fixes #49.This fixes #49.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/91Eudaq2 eventloader2019-03-25T16:42:19+01:00Jens KroegerEudaq2 eventloaderNew Module EventLoaderEUDAQ2 for use at DESY testbeams.
What should be done before merging:
* [x] General code review (variable naming constistent, anything that catches the eye?)
* [x] Is the code commenting fine (I put a lot of comm...New Module EventLoaderEUDAQ2 for use at DESY testbeams.
What should be done before merging:
* [x] General code review (variable naming constistent, anything that catches the eye?)
* [x] Is the code commenting fine (I put a lot of comments everywhere but that might be too much for your taste.)
* [x] Is the README comprehensive enough?
I don't think we have to wait for the ATLASpix with this merge request (it might require some extra if conditions but that should be done in a separate merge request later).https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/90Introduce Event class2019-02-21T17:09:08+01:00Simon SpannagelIntroduce Event classThis replaces the not-so-nice "permament cipboard" usage for start and end of an event with an actual class which can be extended for different use cases.This replaces the not-so-nice "permament cipboard" usage for start and end of an event with an actual class which can be extended for different use cases.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/89Adding figures to Corryvreckan manual2019-01-31T12:00:31+01:00Morag WilliamsAdding figures to Corryvreckan manualAdding figures for data-driven and frame-based readout for correlation chapter, and adding figures from `OnlineMonitoring` and of different reconstruction chains to the `usermanual/figures` directory.Adding figures for data-driven and frame-based readout for correlation chapter, and adding figures from `OnlineMonitoring` and of different reconstruction chains to the `usermanual/figures` directory.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/88Binary pixel2019-01-25T14:45:35+01:00Lennart HuthBinary pixelThe module ClusteringSpatial has not been working for binary pixels without a ToT/adc measurement. Therefore I've added a bool "m_isBinary" to the pixel object to distinguish between pixels with and without charge measures. It is set to ...The module ClusteringSpatial has not been working for binary pixels without a ToT/adc measurement. Therefore I've added a bool "m_isBinary" to the pixel object to distinguish between pixels with and without charge measures. It is set to false per default and should not effect anything if not explicitly changed in an EventLoader.
In addition, a typo in a readme is corrected and another hint to findRoot is added.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/87EventLoaderTimepix3: change current time output log from INFO to DEBUG level.2019-01-11T13:25:25+01:00Morag WilliamsEventLoaderTimepix3: change current time output log from INFO to DEBUG level.Running on default settings, the output of `EventLoaderTimepix3` has lines:
```
|12:57:47.645| (INFO) [R:EventLoaderTimepix3:W0013_L09] Current time: 23.9066s
```
Which is a repetition of the information given by the generic progress ...Running on default settings, the output of `EventLoaderTimepix3` has lines:
```
|12:57:47.645| (INFO) [R:EventLoaderTimepix3:W0013_L09] Current time: 23.9066s
```
Which is a repetition of the information given by the generic progress line:
```
|12:57:47.648| (STATUS) Ev: 18.3k Tr: 48.8k (2.67/ev) t = 23.9066s
```
I have changed this in `log_level` from `INFO` to `DEBUG`. Do you agree with this change @simonspa, @jekroege?https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/86Eventloaderatlaspix documentation2019-01-09T16:48:19+01:00Jens KroegerEventloaderatlaspix documentationCloses #47
Added documentation for missing parameter `legacy_format` and removed unused parameters.Closes #47
Added documentation for missing parameter `legacy_format` and removed unused parameters.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/85usermanual: author list: removed Daniel, added myself2019-01-09T14:19:43+01:00Jens Kroegerusermanual: author list: removed Daniel, added myselfI did as I was told.I did as I was told.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/84Update readme alignment2019-02-07T18:22:28+01:00Jens KroegerUpdate readme alignmentAdding chapter "How to align" to the usermanual.
Not ready for review yet.Adding chapter "How to align" to the usermanual.
Not ready for review yet.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/83improve setup lxplus2018-12-20T10:53:41+01:00Jens Kroegerimprove setup lxplus.gitlab-ci.d/init_x86_64.sh: added "export path-to-corry", so Corryvreckan can be executed everywhere, required for HTCondor submission
If this was the right spot to put it, it should also be put in init_mac.sh. Comments?.gitlab-ci.d/init_x86_64.sh: added "export path-to-corry", so Corryvreckan can be executed everywhere, required for HTCondor submission
If this was the right spot to put it, it should also be put in init_mac.sh. Comments?https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/82jobsub for htcondor2019-01-09T15:05:24+01:00Jens Kroegerjobsub for htcondormodifying jobsub for htcondormodifying jobsub for htcondorhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/81Unify Configuration Keys2019-02-01T15:29:43+01:00Simon SpannagelUnify Configuration KeysThis fixes #46
For review.This fixes #46
For review.