Corryvreckan merge requestshttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests2023-02-24T17:25:33+01:00https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/606AlignmentDUTResidual: Ensure that track fit has not failed2023-02-24T17:25:33+01:00Lennart HuthAlignmentDUTResidual: Ensure that track fit has not failedAs pointed out by @yotarid the module `AlignmentDUTResidual` is not checking if the refit has converged. This PR fixes this by
a) Checking if the refit failed this iteration
b) Refitting if it has failed in the last oneAs pointed out by @yotarid the module `AlignmentDUTResidual` is not checking if the refit has converged. This PR fixes this by
a) Checking if the refit failed this iteration
b) Refitting if it has failed in the last onehttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/605AnalysisEfficiency: fixed axis of global efficiency plots2023-03-02T17:24:35+01:00Adriana SimancasAnalysisEfficiency: fixed axis of global efficiency plotsChanged axis of global efficiency plots to be able to find the sensor even if it's not centered in global coordinates.
**Before the fix:**
The DUT sometimes can be quite off the center of the global coordinates, like in this picture:
!...Changed axis of global efficiency plots to be able to find the sensor even if it's not centered in global coordinates.
**Before the fix:**
The DUT sometimes can be quite off the center of the global coordinates, like in this picture:
![Screenshot_from_2023-02-22_17-12-57](/uploads/2b3ebef31dbb8affdde2e99a7a147671/Screenshot_from_2023-02-22_17-12-57.png)
And the axis of the global efficiency plots are centered at 0 with a relatively small range (1.5 times the size of the DUT), so the plot looks like this:
![Screenshot_from_2023-02-22_17-14-42](/uploads/ff2908b489c7cec828de89d447e0e3dc/Screenshot_from_2023-02-22_17-14-42.png)
**After the fix:**
The axis of the global efficiency plots are now dependent on the DUT global position and it's possible to see where the efficiency is being plotted:
![Screenshot_from_2023-02-24_14-18-57](/uploads/69dab45f3fbb324f6bb64b485d1bf805/Screenshot_from_2023-02-24_14-18-57.png)https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/604Detector: always specify the coordinates after aligning2023-02-23T19:08:12+01:00Lennart HuthDetector: always specify the coordinates after aligningUp to now, only non-cartesian coordinate information has been stored after alignment. I think we should always add this as @yotarid has pointed out in a private chat.
Since this feature has been added by @ebuschma - any objections?Up to now, only non-cartesian coordinate information has been stored after alignment. I think we should always add this as @yotarid has pointed out in a private chat.
Since this feature has been added by @ebuschma - any objections?https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/603log: ensure __LINE__ is evaluated in log var2023-02-23T22:52:24+01:00Stephan Lachnitstephan.lachnit@cern.chlog: ensure __LINE__ is evaluated in log varSee https://gitlab.cern.ch/allpix-squared/allpix-squared/-/merge_requests/954 for details.See https://gitlab.cern.ch/allpix-squared/allpix-squared/-/merge_requests/954 for details.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/599JSONWriter: Request Storage of Object History2023-02-06T12:01:15+01:00Simon SpannagelJSONWriter: Request Storage of Object HistoryThis fixes #180This fixes #180https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/598EUDAQ2: Allow Discarding Events Before Decoding2023-02-06T16:07:54+01:00Simon SpannagelEUDAQ2: Allow Discarding Events Before Decoding...based on their raw event data type, the same as used for the adjust_event_times....based on their raw event data type, the same as used for the adjust_event_times.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/596README: Fix & amend badges2023-02-06T16:11:33+01:00Simon SpannagelREADME: Fix & amend badgeshttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/595Fix author list username links2023-01-27T16:45:00+01:00Simon SpannagelFix author list username links...and some developer status. :slight_smile:...and some developer status. :slight_smile:https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/594Clustering analog add use trigger ts2023-01-27T16:22:47+01:00Finn FeindtClustering analog add use trigger ts* Adding the option to use trigger time stamps instead of seed time stamp as cluster time stamp in `ClusteringAnalog`. Similar as implemented in `ClusteringSpatial`. This is useful in some cases where events are build based on trigger nu...* Adding the option to use trigger time stamps instead of seed time stamp as cluster time stamp in `ClusteringAnalog`. Similar as implemented in `ClusteringSpatial`. This is useful in some cases where events are build based on trigger numbers although time stamps are available.
* Added corresponding entry in documentation.
* Tested enabled myself.
* @naomi tested disabled (default).
* Fixed formulation in the `include_corners` description.Finn FeindtFinn Feindthttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/591Put Authors into separate file2023-01-24T13:48:21+01:00Simon SpannagelPut Authors into separate filehttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/590Implement REUSE specification2023-02-01T14:35:43+01:00Simon SpannagelImplement REUSE specificationThis MR implements the [REUSE](https://reuse.software/) specification.This MR implements the [REUSE](https://reuse.software/) specification.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/589Some Code Cleanup2023-01-24T10:08:29+01:00Simon SpannagelSome Code CleanupJust unifying some headersJust unifying some headershttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/588Additional histograms2023-01-23T12:55:34+01:00Lennart HuthAdditional histograms- Small bugfix in 2 histograms in `DUTAssociation` that are now filled in um instead of the default unit
- New histogram with the 2D difference between clusters and tracks in `DUTAssociation`- Small bugfix in 2 histograms in `DUTAssociation` that are now filled in um instead of the default unit
- New histogram with the 2D difference between clusters and tracks in `DUTAssociation`https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/586F/uncertainties2023-11-23T11:09:08+01:00Lennart HuthF/uncertaintiesProviding the uncertainties in local and global coordinates for GBL as resolution estimation of the trajectory. Defaults to zero for straight lines.
Profits from https://github.com/simonspa/resolution-simulatorProviding the uncertainties in local and global coordinates for GBL as resolution estimation of the trajectory. Defaults to zero for straight lines.
Profits from https://github.com/simonspa/resolution-simulatorhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/585Module AlignmentTime2024-01-31T07:04:20+01:00Finn FeindtModule AlignmentTimeStill a draft. See README.md for more detailed module description. I would like to discuss if this module makes sense at all, and possible changes before I put more efforts in. Topics for discussion:
* At the moment, the module uses pixe...Still a draft. See README.md for more detailed module description. I would like to discuss if this module makes sense at all, and possible changes before I put more efforts in. Topics for discussion:
* At the moment, the module uses pixel time stamps. So one needs to build events using the metronome, which can be a bit tricky, e.g. when time stamps are provided by an auxiliary detector.
* The guessing of initial parameters for the search can be optimized, but I think in the end users will need to configure the search properly.
* Should one do a coarse and a fine search automatically?
* Should one automatically add the shift to the geometry file?
* Add output plots for clock drifts?
This closes #93Finn FeindtFinn Feindthttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/583Issue a warning for large histograms2022-12-13T15:57:38+01:00Lennart HuthIssue a warning for large histogramsPlotting residuals as a function of time causes corry to crash. @ffeindt reported me the issue and it is caused by huge root histograms filled for bad combinations of binning and resolution. Since users might want this plot in large deta...Plotting residuals as a function of time causes corry to crash. @ffeindt reported me the issue and it is caused by huge root histograms filled for bad combinations of binning and resolution. Since users might want this plot in large detail I've added a warning if the histogram contains more than 3 million bins.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/580Fix Default Unit of B Field Strength2022-12-01T15:15:39+01:00Simon SpannagelFix Default Unit of B Field StrengthSee https://gitlab.cern.ch/allpix-squared/allpix-squared/-/merge_requests/835
Wrong documentation was all.See https://gitlab.cern.ch/allpix-squared/allpix-squared/-/merge_requests/835
Wrong documentation was all.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/579Fix newline in AnalysisDUT README2022-12-01T11:33:22+01:00Finn FeindtFix newline in AnalysisDUT READMEJust a quick fix of a user manual formatting issue.Just a quick fix of a user manual formatting issue.https://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/578EtaCalculation: fixes, EtaCorrection: refactor2022-11-25T14:53:17+01:00Peter SvihraEtaCalculation: fixes, EtaCorrection: refactor* get rid of unnecessary detector name in config
* refactored eta correction
* added plot to eta correction* get rid of unnecessary detector name in config
* refactored eta correction
* added plot to eta correctionhttps://gitlab.cern.ch/corryvreckan/corryvreckan/-/merge_requests/576Codespell: Ignore PDF Files2022-11-23T21:08:46+01:00Simon SpannagelCodespell: Ignore PDF Files..otherwise it gets wild...otherwise it gets wild.